-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote: Fix performance regression in "upload missing inputs". #15890
Conversation
I tested locally that the "collect digests" part is back to normal. @clint-stripe Can you please give it a try? |
@bazel-io flag |
6c2b485
to
a2be64d
Compare
@bazel-io fork 5.3.0 |
@ckolli5 is this something we could cherry-pick into 5.2? We're stuck on Bazel 5.0 without this fix, and waiting until 5.3 is released in August is not ideal. |
@clint-stripe Making a 5.2.1 release to cherry-picking this change won't be much faster than the 5.3 release, we still have to go through the same release process. So please wait for 5.3, thanks! |
It might be helpful to get an RC out for 5.3 (or some bazelisk pointable binary). We have lots of changes in the branch, but no built binaries to test yet. |
a32df05
to
d5363a3
Compare
@brentleyjones Actually, you can use |
d5363a3
to
b576aff
Compare
Also add more tests. Fixes bazelbuild#15872.
b576aff
to
3e08a8d
Compare
The regression was introduced in 702df84 where we essentially create a subscriber for each digest to subscribe the result of `findMissingBlobs`. This change update the code to not create so many subscribers but maintain the same functionalities. Fixes bazelbuild#15872. Closes bazelbuild#15890. PiperOrigin-RevId: 463826260 Change-Id: Id0b1c7c309fc9653a47c5df95c609b34e6510cde
The regression was introduced in 702df84 where we essentially create a subscriber for each digest to subscribe the result of `findMissingBlobs`. This change update the code to not create so many subscribers but maintain the same functionalities. Fixes #15872. Closes #15890. PiperOrigin-RevId: 463826260 Change-Id: Id0b1c7c309fc9653a47c5df95c609b34e6510cde
The regression was introduced in 702df84 where we essentially create a subscriber for each digest to subscribe the result of
findMissingBlobs
.This change update the code to not create so many subscribers but maintain the same functionalities.
Fixes #15872.