Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve --experimental_allow_unresolved_symlinks in exec cfg #15702

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jun 19, 2022

See #10298 (comment)

Work towards #10298

@fmeum
Copy link
Collaborator Author

fmeum commented Jun 19, 2022

@lberki Could you take a look?

@fmeum fmeum marked this pull request as ready for review June 19, 2022 16:13
@sgowroji sgowroji added team-Core Skyframe, bazel query, BEP, options parsing, bazelrc awaiting-review PR is awaiting review from an assigned reviewer labels Jun 20, 2022
@lberki
Copy link
Contributor

lberki commented Jun 20, 2022

/cc @katre

I can't imagine you not wanting this change, so I'll go ahead and approve it.

Copy link
Contributor

@lberki lberki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! You even added a test case :)

@lberki lberki added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jun 21, 2022
@katre
Copy link
Member

katre commented Jun 21, 2022

@lberki Will you merge, or shall I?

@lberki
Copy link
Contributor

lberki commented Jun 21, 2022

@katre I thought that that's what the "awaiting-PR-merge" label is for and that gTech is taking care of it now. That said, if it's urgent I can merge it myself (tomorrow)

@katre
Copy link
Member

katre commented Jun 21, 2022

I had no idea that label existed. The future is now!

@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jun 22, 2022
@brentleyjones
Copy link
Contributor

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jun 22, 2022
@ckolli5
Copy link

ckolli5 commented Jun 22, 2022

@bazel-io fork 5.3.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jun 22, 2022
aranguyen pushed a commit to aranguyen/bazel that referenced this pull request Jun 27, 2022
See bazelbuild#10298 (comment)

Work towards bazelbuild#10298

Closes bazelbuild#15702.

PiperOrigin-RevId: 456480627
Change-Id: Ib1237ce9e2c0bab0d7eabd8743f08ec60b8b7ab7
ckolli5 added a commit that referenced this pull request Jun 27, 2022
See #10298 (comment)

Work towards #10298

Closes #15702.

PiperOrigin-RevId: 456480627
Change-Id: Ib1237ce9e2c0bab0d7eabd8743f08ec60b8b7ab7

Co-authored-by: Fabian Meumertzheim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Core Skyframe, bazel query, BEP, options parsing, bazelrc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants