Reduce imports processed by python stubs. #15572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are several import statements in the python wrapper stub used by `py_binary` and `py_test` rules which are only used when running from a zip archive. Processing these imports is a waste of time in the common case where they aren't going to be used. They also might not be present at all in some stripped-down python environments (e.g. the Debian `python3-minimal` package), which might be the only python available on a remote builder when using a hermetic python toolchain (even when using a hermetic python toolchain, the wrapper is executed using the system python environment).
sgowroji
added
team-Rules-Python
|
cc @brandjon do you see any problems with this? |
comius
approved these changes
May 27, 2022
ShreeM01
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several import statements in the python wrapper stub used by
py_binaryandpy_testrules which are only used when running from azip archive. Processing these imports is a waste of time in the common
case where they aren't going to be used. They also might not be
present at all in some stripped-down python environments (e.g. the
Debian
python3-minimalpackage), which might be the only pythonavailable on a remote builder when using a hermetic python toolchain
(even when using a hermetic python toolchain, the wrapper is executed
using the system python environment).
Closes #15571