Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept tildes in --override_repository #15417

Closed

Conversation

keith
Copy link
Member

@keith keith commented May 7, 2022

This is useful for adding this in your global ~/.bazelrc file for easy
rules debugging.

This is useful for adding this in your global ~/.bazelrc file for easy
rules debugging.
@sgowroji sgowroji added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels May 7, 2022
@meteorcloudy meteorcloudy requested a review from Wyverald July 12, 2022 12:28
Copy link
Member

@Wyverald Wyverald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jul 12, 2022
@brentleyjones
Copy link
Contributor

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jul 13, 2022
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jul 13, 2022
@sgowroji
Copy link
Member

@bazel-io fork 5.3.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jul 13, 2022
sgowroji pushed a commit to sgowroji/bazel that referenced this pull request Jul 13, 2022
This is useful for adding this in your global ~/.bazelrc file for easy
rules debugging.

Closes bazelbuild#15417.

PiperOrigin-RevId: 460689663
Change-Id: I12206d24002e606f3769bb3faed0b73701ed5aad
@ckolli5
Copy link

ckolli5 commented Jul 14, 2022

Hey @keith, we are trying to cherry pick this change to the release-5.3.0. But presubmit checks are failing due to missing dependencies. So, could you please help us in cherry picking this change with appropriate commits? Thanks!

@keith keith deleted the ks/accept-tildes-in-override_repository branch July 14, 2022 16:20
@keith
Copy link
Member Author

keith commented Jul 14, 2022

I don't really mind if this makes it into 5.3.0 or not, so someone else can try to take it on or we can skip it

aranguyen pushed a commit to aranguyen/bazel that referenced this pull request Jul 20, 2022
This is useful for adding this in your global ~/.bazelrc file for easy
rules debugging.

Closes bazelbuild#15417.

PiperOrigin-RevId: 460689663
Change-Id: I12206d24002e606f3769bb3faed0b73701ed5aad
aranguyen pushed a commit to aranguyen/bazel that referenced this pull request Jul 20, 2022
This is useful for adding this in your global ~/.bazelrc file for easy
rules debugging.

Closes bazelbuild#15417.

PiperOrigin-RevId: 460689663
Change-Id: I12206d24002e606f3769bb3faed0b73701ed5aad
@ckolli5
Copy link

ckolli5 commented Jul 21, 2022

Hey @brentleyjones, based on the above comment. Should we still consider this as a release blocker?

@brentleyjones
Copy link
Contributor

@ckolli5, no. If it was easy to land it would have been nice, but let's drop it from 5.3. Thanks!

keith added a commit to keith/bazel that referenced this pull request Jan 13, 2023
This is useful for adding this in your global ~/.bazelrc file for easy
rules debugging.

See also bazelbuild#15417
keith added a commit to keith/bazel that referenced this pull request Jan 13, 2023
This is useful for adding this in your global ~/.bazelrc file for easy
rules debugging.

See also bazelbuild#15417
keith added a commit to keith/bazel that referenced this pull request Jan 15, 2023
This is useful for adding this in your global ~/.bazelrc file for easy
rules debugging.

See also bazelbuild#15417
copybara-service bot pushed a commit that referenced this pull request Jan 18, 2023
This is useful for adding this in your global ~/.bazelrc file for easy rules debugging.

See also #15417

Closes #17218.

PiperOrigin-RevId: 502854597
Change-Id: Ic26289c6497edd31187dde2c7cda78c2177a56c4
ShreeM01 added a commit that referenced this pull request Jan 25, 2023
This is useful for adding this in your global ~/.bazelrc file for easy rules debugging.

See also #15417

Closes #17218.

PiperOrigin-RevId: 502854597
Change-Id: Ic26289c6497edd31187dde2c7cda78c2177a56c4

Co-authored-by: Keith Smiley <[email protected]>
hvadehra pushed a commit that referenced this pull request Feb 14, 2023
This is useful for adding this in your global ~/.bazelrc file for easy rules debugging.

See also #15417

Closes #17218.

PiperOrigin-RevId: 502854597
Change-Id: Ic26289c6497edd31187dde2c7cda78c2177a56c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants