ijar Kotlin handling #15355
Closed
ijar Kotlin handling #15355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused handling of the `KeepForCompile` attribute, and instead check for the `@kotlin.Metadata` annotation and preserve all Kotlin classes. bazelbuild#4549 RELNOTES: Make ijar / java_import preserve classes with `@kotlin.Metadata` annotations PiperOrigin-RevId: 441243993
|
@cpsauer FYI |
|
@ckolli5 I have hit this seemingly unrelated CI failure ( |
sgowroji
added
awaiting-user-response
|
Thanks for the heads, @fmeum! I'll update a couple of other issues, downstream :) |
This was referenced May 5, 2022
|
Driveby comment. Ijar is released with java_tools. Cherry-picking just ijar, won't make a difference - except maybe for book-keeping. java_tools version should be updated. cc @hvadehra |
|
Thanks for the comment, looks like this already got into 5.2.0 with bbcff18 then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused handling of the
KeepForCompileattribute, and instead check forthe
@kotlin.Metadataannotation and preserve all Kotlin classes.#4549
RELNOTES: Make ijar / java_import preserve classes with
@kotlin.MetadataannotationsPiperOrigin-RevId: 441243993