Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.1] Remote: Don't check TreeArtifact output #15085

Merged
merged 1 commit into from
Mar 21, 2022
Merged

[5.1] Remote: Don't check TreeArtifact output #15085

merged 1 commit into from
Mar 21, 2022

Commits on Mar 21, 2022

  1. Remote: Don't check TreeArtifact output 

    With a151116, we ignore action cache entry when checking the remote cache if a mandatory output of the Spawn is missing.

However, this breaks Spawns that declare a directory output but don't generate anything under it. Since remote servers typically don't create directory ahead of time, and if the action itself doesn't create files under the directory, that directory will be eliminated from the action cache entry.

This PR fixes that by not checking TreeArtifact output.

Closes bazelbuild#15077.

PiperOrigin-RevId: 436163970
(cherry picked from commit f585783)
    @coeuvre @brentleyjones
    coeuvre authored and brentleyjones committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    ff07705 View commit details
    Browse the repository at this point in the history