Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Add "arch" struct field to repository_os #14835

Commits on Feb 16, 2022

  1. Add "arch" struct field to repository_os

    This new field provides access to the Java "os.arch" property to
    repository rules, which previously had to rely on uname (Unix) or
    additional env variables (Windows) to detect the architecture.
    
    This also fixes a small issue in the existing implementation of
    repository_ctx.os.name, which should use the root locale when converting
    the value of the "os.name" property to lowercase.
    
    Existing sites of manual architecture detection in shipped repository
    rules as well as redundant calls to lower() on the value of
    repository_ctx.os.name are cleaned up.
    
    Fixes bazelbuild#14685
    
    Closes bazelbuild#14738.
    
    PiperOrigin-RevId: 427147225
    (cherry picked from commit 32d1606)
    fmeum authored and brentleyjones committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    65cca80 View commit details
    Browse the repository at this point in the history