-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove --experimental_worker_allow_json_protocol #14679
Remove --experimental_worker_allow_json_protocol #14679
Conversation
cc @aiuto |
Enabling this feature by default should be cherry picked into 5.x, so if we merge this now and leave until 6.x for folks to remove this flag from their configs, that seems safe |
I'm not that familiar with workers, so I'd like to get an expert review from @larsrc-google |
My 2 cents: |
I defer to Lars's expert opinion :) We should flip the flag internally before removing it, but I support doing both of those things. |
@susinmotion The flag is already flipped internally and doesn't seem to be causing any harm. So we can indeed remove this. I don't see any reason to backport it, though. |
54ac930
to
a920195
Compare
updated the docs |
Port bazelbuild/bazel#14679 into `rules_ios` to prepare for Bazel 6.0.0.
Port bazelbuild/bazel#14679 into `rules_ios` to prepare for Bazel 6.0.0.
This flag has been flipped, and unlike other experimental flags there is no reason to disable it because workers can only support a single format at once, so if they rely on this, you just wouldn't be able to build.
Closes #13599