Prevent temporary intermediate files from being picked up by Android ResourceCompiler when building with workers. #14198
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ResourceCompiler when running with workers. When `--persistent_android_resource_processor` is used alongside databinding, ResourceCompiler reads `databinding-processed-resources` during resource merging and that folder can contain ``*.params` file for each processed layout resource. This causes resource compiler's file name validation to fail. This CL simply ignores staging the intermediate files for resource compilation. Additionally this CL also excludes *.tmp files which were observed when using dynamic execution. Fixes bazelbuild#13649
|
Thanks, I'll start importing this now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
--persistent_android_resource_processoris used alongside databinding,ResourceCompilerreadsdatabinding-processed-resourcesfolder during resource merging and that folder can contain*.paramsfile used for thePROCESS_DATABINDINGaction. This causes resource compiler's file name validation to fail. This CL simply ignores staging the intermediate files for resource compilation.Additionally this CL also excludes
*.tmpfiles which were observed when using dynamic remote execution.Fixes #13649