Avoid leaking ResourceShrinkerAction args between requests #14145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction-args-between-requests
…ction-args-between-requests
copybara-service bot
pushed a commit
that referenced
this pull request
Jun 22, 2022
Adding support for multiplex workers inside of `ResourceProcessorBusyBox` and moving it's worker implementation over to the generic work request handler. These PRs need to land for this to work: - #14424 - #14425 - #14427 For those not on rolling releases, the other required PRs that have already merged are: - #14144 - #14145 - #14146 Closes #14428. PiperOrigin-RevId: 456561596 Change-Id: I098d5a323ac6558ad0f5f8190e29f45a7a37b4d4
aranguyen
pushed a commit
to aranguyen/bazel
that referenced
this pull request
Jun 27, 2022
Adding support for multiplex workers inside of `ResourceProcessorBusyBox` and moving it's worker implementation over to the generic work request handler. These PRs need to land for this to work: - bazelbuild#14424 - bazelbuild#14425 - bazelbuild#14427 For those not on rolling releases, the other required PRs that have already merged are: - bazelbuild#14144 - bazelbuild#14145 - bazelbuild#14146 Closes bazelbuild#14428. PiperOrigin-RevId: 456561596 Change-Id: I098d5a323ac6558ad0f5f8190e29f45a7a37b4d4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping the
ResourceShrinkerActionoptions in a static field allows these options to leak between requests in a multiplex world.