Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Java 17 toolchain #14040

Closed
wants to merge 1 commit into from
Closed

Add a Java 17 toolchain #14040

wants to merge 1 commit into from

Conversation

cushon
Copy link
Contributor

@cushon cushon commented Sep 26, 2021 •
edited
Loading

@cushon cushon requested a review from comius September 26, 2021 02:42
@google-cla google-cla bot added the cla: yes label Sep 26, 2021
@meteorcloudy
Copy link
Member

https://mirror.bazel.build/cdn.azul.com/zulu/bin/zulu17.28.13-ca-jdk17.0.0-linux_x64.tar.gz
https://mirror.bazel.build/cdn.azul.com/zulu/bin/zulu17.28.13-ca-jdk17.0.0-macosx_x64.tar.gz
https://mirror.bazel.build/cdn.azul.com/zulu/bin/zulu17.28.13-ca-jdk17.0.0-macosx_aarch64.tar.gz
https://mirror.bazel.build/cdn.azul.com/zulu/bin/zulu17.28.13-ca-jdk17.0.0-win_x64.zip

are now available

@davido
Copy link
Contributor

davido commented Sep 27, 2021

Mention issue #13416?

comius
comius approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@comius comius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Sorry, for having so many locations that need updating.

The tests need java_tools update right?

@cushon
Copy link
Contributor Author

cushon commented Sep 28, 2021

The tests need java_tools update right?

Yep--I updated to the new release, and the tests are passing now. I think this is ready to go.

@bazel-io bazel-io closed this in eb7bf8c Sep 30, 2021
@strophy strophy mentioned this pull request Mar 9, 2023
Closed
@catap catap mentioned this pull request May 2, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comius comius comius approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cushon @meteorcloudy @davido @comius