Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide the default lcov_merger to all Starlark tests #13983

Closed
wants to merge 1 commit into from
Closed

Provide the default lcov_merger to all Starlark tests #13983

wants to merge 1 commit into from

Commits on Sep 13, 2021

  1. Provide the default lcov_merger to all Starlark tests 

    Since 5b216b2, all Starlark-defined test rules either need to set the
`_lcov_merger` attribute or fail if run with `bazel coverage`. This is
fixed by attaching the default lcov merger as a late-bound default to
all Starlark rules via a new attribute and falling back to that
attribute in the TestActionBuilder.

This commit ensures backwards compatibility is maintained with existing
Starlark test rules that set the `_lcov_merger` attribute. This is also
verified in the included integration test.

Fixes bazelbuild#13978.
    @fmeum
    fmeum committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    43191ee View commit details
    Browse the repository at this point in the history