Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly report error when HTTP connection was closed before Content-Length was fulfilled. #13918

Closed
wants to merge 2 commits into from

Conversation

coeuvre
Copy link
Member

@coeuvre coeuvre commented Aug 30, 2021

Instead of reporting checksum mismatch, the downloader will now report

Connection was closed before Content-Length was fulfilled. Bytes read %s but wanted %s

when HTTP connection is closed before Content-Length is fulfilled.

Fixes #12010.

@google-cla google-cla bot added the cla: yes label Aug 30, 2021
@coeuvre coeuvre requested a review from philwo August 30, 2021 03:10
Copy link

@whsiao whsiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval for the new test cases. Get philwo's approval for the other parts of your changes outside of the test cases, since I'm not familiar with those parts.

@bazel-io bazel-io closed this in 0e90eab Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downloads can be truncated and report an incorrect sha256sum
3 participants