Fix action conflict on exec transitioned cc_proto_library #13875
Conversation
|
Is this PR ready to be reviewed? It's still in the DRAFT state. If so, please attach an issue describing the problem being fixed, ideally with a reproduction of the issue, so that I can verify what's happening. |
|
This is ready for review now. I failed to come up with a Bazel integration test that would actually reproduce the conflicting actions without this fix, perhaps because |
When the proto rules' depdencies were switched over to the exec config in 7acf9ea, the dependency of CcProtoAspect on the proto C++ toolchain was not updated. Due to this, cc_proto_library had two dependencies on @com_google_protobuf//:protobuf (through :protoc and directly) with potentially incompatible configurations, which lead to conflicting actions. Fixes bazelbuild#13464.
|
@sdtwigg I'm sorry, it seems that I got ahead of myself here: While the tests pass and the reproducer for #13464 no longer errors out with this patch, it is probably not semantically correct as it seems it would end up building the |
When the proto rules' depdencies were switched over to the exec config in
7acf9ea, the dependency of CcProtoAspect on the
proto C++ toolchain was not updated. Due to this, cc_proto_library had two
dependencies on @com_google_protobuf//:protobuf (through :protoc and directly)
with potentially incompatible configurations, which lead to conflicting actions.
Fixes #13464.