Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes incorrect install names on darwin platforms #13427

Closed
wants to merge 1 commit into from
Closed

Fixes incorrect install names on darwin platforms #13427

wants to merge 1 commit into from

Commits on May 5, 2021

  1. Fixes incorrect install names on darwin platforms 

    #12304 added support to bazel for setting install names for dynamic
libraries on darwin platforms. This would set LC_ID_DYLIB to
@rpath/{library_name}, so that RPATH would be used to locate these
libraries at runtime. However, the code was using a utility method that
assumed the library name was mangled, which is often not the case. Given
that the output path should already have been determined with the
mangled or unmangled name, we should be able to just use the base name
of the artifact. The test that was added in #12304 has been updated to
actually use dynamic libaries, and passes with the changes made in this
commit.
    @csmulhern
    csmulhern committed May 5, 2021
    Configuration menu
    Copy the full SHA
    ccecff9 View commit details
    Browse the repository at this point in the history