Allow oso_prefix_is_pwd to be used with all osx cpp link actions #13311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands the targeted actions to allow stripping the absolute build path for debug symbols from all libraries. The support in wrapped_clang is indifferent to whether we are linking a true objc or regular cpp library.
When used in concert with
--features=oso_prefix_is_pwd --remote_download_outputs=all, allows successful local debugging of executables/libraries built remotely. Probably also helps with sandboxed actions.Helps mitigate #6327 and kinda sorta #2537? See also #11671