Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert special characters in classpath to hexadecimal representation in java_stub_template #12969

Closed
wants to merge 1 commit into from

Conversation

mai93
Copy link
Contributor

@mai93 mai93 commented Feb 5, 2021

This PR fixes the url-encoding in java_stub_template to convert different special characters to their 2-digit hexadecimal representation.

Fixes: #10620

@google-cla google-cla bot added the cla: yes label Feb 5, 2021
@mai93 mai93 requested a review from meteorcloudy February 5, 2021 11:37
@mai93 mai93 marked this pull request as ready for review February 5, 2021 11:37
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you refer to the github issue link this PR tries to solve?

@bazel-io bazel-io closed this in d0ee889 Feb 5, 2021
Bencodes pushed a commit to Bencodes/bazel that referenced this pull request Mar 23, 2021
…n in java_stub_template

This PR fixes the url-encoding in `java_stub_template` to convert different special characters to their 2-digit hexadecimal representation.

Fixes: bazelbuild#10620

Closes bazelbuild#12969.

PiperOrigin-RevId: 355838382
Bencodes pushed a commit to lyft/bazel that referenced this pull request Apr 20, 2021
…n in java_stub_template

This PR fixes the url-encoding in `java_stub_template` to convert different special characters to their 2-digit hexadecimal representation.

Fixes: bazelbuild#10620

Closes bazelbuild#12969.

PiperOrigin-RevId: 355838382
Bencodes pushed a commit to lyft/bazel that referenced this pull request May 6, 2021
…n in java_stub_template

This PR fixes the url-encoding in `java_stub_template` to convert different special characters to their 2-digit hexadecimal representation.

Fixes: bazelbuild#10620

Closes bazelbuild#12969.

PiperOrigin-RevId: 355838382
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bazel creates non-compliant classpath jar
2 participants