Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify test_suite behaviour in the Platforms docs #12870

Closed
wants to merge 1 commit into from

Conversation

philsc
Copy link
Contributor

@philsc philsc commented Jan 21, 2021

The current test_suite behaviour in regards to incompatible target
skipping is subtle and not necessarily obvious. This patch aims to
clear up some of the confusion.

Copy link
Contributor

@gregestren gregestren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! This is a good, and I think relevant, clarification.

site/docs/platforms.md Outdated Show resolved Hide resolved
site/docs/platforms.md Outdated Show resolved Hide resolved
@aiuto aiuto removed their request for review January 22, 2021 01:23
The current `test_suite` behaviour in regards to incompatible target
skipping is subtle and not necessarily obvious. This patch aims to
clear up some of the confusion.
@philsc philsc force-pushed the platforms-doc-update branch from 62853f2 to 3afff63 Compare January 22, 2021 05:52
Copy link
Contributor

@gregestren gregestren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for considering such nitty suggestions!

@bazel-io bazel-io closed this in c71697c Jan 22, 2021
@philsc philsc deleted the platforms-doc-update branch January 23, 2021 05:13
philwo pushed a commit that referenced this pull request Mar 15, 2021
The current `test_suite` behaviour in regards to incompatible target
skipping is subtle and not necessarily obvious. This patch aims to
clear up some of the confusion.

Closes #12870.

PiperOrigin-RevId: 353293585
philwo pushed a commit that referenced this pull request Mar 15, 2021
The current `test_suite` behaviour in regards to incompatible target
skipping is subtle and not necessarily obvious. This patch aims to
clear up some of the confusion.

Closes #12870.

PiperOrigin-RevId: 353293585
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants