Simplify updating our dependency on rules_java. #12734
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a capability to generate WORKSPACE files for tests at build time, based on the repository definitions in distdir_deps.bzl. This makes it possible for the versions of repositories used in tests to align with the versions used a Bazel build time without upddating files scattered throughout the source and test trees. Demonstrated with rules_cc.
|
cc: @jitsu-net This is an example of some of the test brittleness I was talking about last week. Before this change, if you wanted to update the version of rules_cc we used, you needed to edit multiple files. With this change, you do it in a single configuration file. |
…srcs.tar This makes me think that the overall distfile build test is broken. You should be able to regenerate these files from the sources.
aiuto
changed the title
bazel-io
pushed a commit
that referenced
this pull request
Jan 5, 2021
… http_archive More for #12081 For dependencies specified in distdir.bzl, we can now include them in Bazel's WORKSPACE with a simpler invocation that can not go out of sync. For example, this ``` dist_http_archive( name = "io_bazel_rules_sass", ) ``` instead of ``` http_archive( name = "io_bazel_rules_sass", sha256 = "c78be58f5e0a29a04686b628cf54faaee0094322ae0ac99da5a8a8afca59a647", strip_prefix = "rules_sass-1.25.0", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_sass/archive/1.25.0.zip", "https://github.com/bazelbuild/rules_sass/archive/1.25.0.zip", ], ) ``` Also, convert two more packages only used at Bazel build time to the new style. Next steps: - convert other repositories which are not needed at run time to this format - add ability to generate WORKSPACE files used by tests from DISTDIR #12734 - convert rules libraries to this format Closes #12722. PiperOrigin-RevId: 350140996
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More progress on #12081. With this change, updating our version of rules_java requires only editing contiguous lines in a single file.
Status: WIP. Incremental PR on top of #12743 and #12722. When those merge, this will reduce in size.