-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the classic query package-loading cutoff optimization with external workspaces. #12595
Conversation
Reassigned to @meisterT for further triage since this is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a simple test?
Are there a lot of internal tests for query? |
I assumed you would add the test here: https://github.com/bazelbuild/bazel/blob/master/src/test/shell/integration/bazel_query_test.sh |
I can do that. Normally, I make some effort to not write shell integration tests, though, since bash is not a very good programming language. |
30ef3d5
to
43ceefb
Compare
…al workspaces. A package's path fragment is not unambiguous when external workspaces are involved. Fixes bazelbuild#12497.
43ceefb
to
482d24a
Compare
…al workspaces. A package's path fragment is not unambiguous when external workspaces are involved. Fixes bazelbuild#12497. Closes bazelbuild#12595. PiperOrigin-RevId: 346048937
A package's path fragment is not unambiguous when external workspaces are involved.
Fixes #12497.