Update rules_pkg to 0.2.5 and use real rules_python #11191
Conversation
| # XXXX This is a mock version of bazelbuild/rules_python that contains only | ||
| # @rules_python//python:defs.bzl. It is used by protobuf. | ||
| # TODO(#9029): We could potentially replace this with the real @rules_python. | ||
| #new_local_repository( | ||
| # name = "rules_python", | ||
| # build_file = "//third_party/rules_python:BUILD", | ||
| # path = "./third_party/rules_python", | ||
| # workspace_file = "//third_party/rules_python:rules_python.WORKSPACE", | ||
| #) |
There was a problem hiding this comment.
I think you intended to delete these lines?
There was a problem hiding this comment.
Yes. I just have not yet because I keep flipping back and forth to figure out the build error.
| #new_local_repository( | ||
| # name = "rules_python", | ||
| # build_file = "//third_party/rules_python:BUILD", | ||
| # path = "./third_party/rules_python", |
There was a problem hiding this comment.
Seems we can submit a follow-up to remove this stub repo from //third_party. I'll draft the PR. (Can't be in this PR since we can't do third_party changes atomically with ordinary changes.)
There was a problem hiding this comment.
That was my intent, but the failures are not transient. They reproduce locally. All of the protobufs go wonky.
|
No idea what the test failures are about... transient issue with unpacking third_party? |
|
What's the status of this PR? |
|
It is still a WIP blocked on #9046. That, in turn, is a WIP which turned into an overly complex project because the workspace tests should not depend on pkg_tar. |
|
Abandoning this line of reasoning. The tests should be rewritten to not depend on rules_pkg, and thus, transitively, rules_python. |
No description provided.