Windows: Use vswhere to locate latest Visual C++ installation #10805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When nothing matches |
gjasny
force-pushed
the
vs2019-vswhere
branch
from
22b6c12 to
6ffe3f7
Compare
|
The build error looks unrelated. |
meteorcloudy
requested review from
meteorcloudy
and removed request for
laszlocsomor
Starting with Visual Studio 15.2 vswhere.exe is installed into `%ProgramFiles(x86)%\Microsoft Visual Studio\Installer`. We locate the latest non-prerelease version which has the C++ x64/x86 build tools installed. Closes: bazelbuild#10772
I'd merge this one before. The environment variable lookup problems do not influence this PR (more than before). I guess most users have their "Program Files" folder on the C-drive anyways. |
meteorcloudy
approved these changes
Mar 9, 2020
philwo
added
the
team-OSS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Visual Studio 15.2 vswhere.exe is installed into
%ProgramFiles(x86)%\Microsoft Visual Studio\Installer.We locate the latest non-prerelease version which has the
Desktop development with C++ workload installed.
Closes: #10772