Multiplex Workers documentation #10108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
I'm turfing this to @philwo because he should be a better reviewer for this than I would be. |
philwo
reviewed
Oct 31, 2019
site/docs/multiplex-worker.md
Outdated
|
|
||
| ## A Guide to Write a Multiplex-Compatible Ruleset | ||
|
|
||
| The rule's worker process should be multi-threaded to take advantage of Multiplex Workers. Protobuf allows a ruleset to parse a single request even though there might be multiple requests piling up in the stream. Whenever the worker process parses a request from the stream, it should handle the request in a new thread. Since different thread could complete and write to the stream at the same time, the ruleset needs to make sure the responses are written atomically (i.e. messages don't overlap). Responses must contain the `request_id` of the request they're handling. |
There was a problem hiding this comment.
I would replace "the ruleset needs to make sure" with "the worker process needs to make sure" (because this locking as to be implemented in the worker process, not in the Starlark rules).
|
@philwo friendly ping here. Would you be able to take another look? |
|
Sorry @borkaehw! Merging this now. |
|
Thanks @philwo. How can we wire it up so people can read it in webpage form? |
|
Never mind, it seems to be automatic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A documentation for Multiplex Workers. See the original PR for details. #6857
Fix: #2832