Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS: cannot build rules_nodejs with Bazel@HEAD #9054

Closed
laszlocsomor opened this issue Aug 2, 2019 · 6 comments
Closed

macOS: cannot build rules_nodejs with Bazel@HEAD #9054

laszlocsomor opened this issue Aug 2, 2019 · 6 comments

Comments

@laszlocsomor
Copy link
Contributor

Description of the problem / feature request:

On macOS, Bazel at HEAD (7b7d5b9) cannot build rules_nodejs at its HEAD (bazel-contrib/rules_nodejs@64d3059).

Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1116#101b38bb-21f2-49b6-afac-ddb51690621a

What operating system are you running Bazel on?

macOS
@laszlocsomor laszlocsomor changed the title macOS: cannot build rules_nodejs macOS: cannot build rules_nodejs with Bazel@HEAD Aug 2, 2019
@laszlocsomor
Copy link
Contributor Author

Culprit finder blames c35878a.

https://buildkite.com/bazel/culprit-finder/builds/186#99e5bcb1-8dcf-4410-85a2-429518a588ad

/cc @lberki

@lberki
Copy link
Contributor

lberki commented Aug 2, 2019

How do I reproduce this?

bazel build //src:bazel (at HEAD)
git clone https://github.com/bazelbuid/rules_nodejs
cd rules_nodejs
bazel build @nodejs//:yarn

passes.

@lberki
Copy link
Contributor

lberki commented Aug 2, 2019

Oh. Nevermind. OS X only.

Well, now the question is how do I reproduce that without an OS X machine....

@laszlocsomor
Copy link
Contributor Author

Use Bazel built at 7b7d5b9, not release Bazel.

@lberki
Copy link
Contributor

lberki commented Aug 2, 2019

Of course. The question is how do I reproduce an OS X-only change without an OS X machine.

@laszlocsomor
Copy link
Contributor Author

We have a shared macOS machine. I'll send you the details offline.

@lberki lberki mentioned this issue Aug 2, 2019
Closed
bazel-io pushed a commit that referenced this issue Jul 22, 2020
@justinhorvitz @copybara-github
Add test coverage for tree artifacts containing directory symlinks.
42b461b 
We have been bitten twice by this use case. See #9054 and #11813.

Fixes #9058.

RELNOTES: None.
PiperOrigin-RevId: 322590818
ehkloaj pushed a commit to ehkloaj/bazel that referenced this issue Aug 6, 2020
@justinhorvitz @ehkloaj
Add test coverage for tree artifacts containing directory symlinks.
d399222 
We have been bitten twice by this use case. See bazelbuild#9054 and bazelbuild#11813.

Fixes bazelbuild#9058.

RELNOTES: None.
PiperOrigin-RevId: 322590818
luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this issue Sep 4, 2022
Add test coverage for tree artifacts containing directory symlinks.
e83d4f8 
    We have been bitten twice by this use case. See bazelbuild/bazel#9054 and bazelbuild/bazel#11813.

    Fixes #9058.

    RELNOTES: None.
    PiperOrigin-RevId: 322590818
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lberki @laszlocsomor