Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py_test/sh_test pulls in unnecessary java repositories at runtime (0.26) #8575

Closed
Profpatsch opened this issue Jun 6, 2019 · 4 comments
Closed
Labels
coverage P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Rules-Java Issues for Java rules type: bug

Comments

@Profpatsch
Copy link
Contributor

Description of the problem / feature request:

Bazel 0.26 tries to download remote_java_tools_linux for a trivial BUILD file using the py_binary rule.

I’d expect bazel to support its builtin rules without depending on external repositories.

Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

Please see the minimal repro here: https://github.com/Profpatsch/repros/tree/master/bazel-python_binary-downloads-repostitories

Go offline and run the command in the repro.

What operating system are you running Bazel on?

$ uname -a
Linux shiki 4.19.34 #1-NixOS SMP Fri Apr 5 20:33:17 UTC 2019 x86_64 GNU/Linux

What's the output of bazel info release?

$ bazel info release
release 0.26.0- (@non-git)

If bazel info release returns "development version" or "(@non-git)", tell us how you built Bazel.

$ git clone https://github.com/NixOS/nixpkgs
$ git fetch [email protected]:groodt/nixpkgs bazel-0.26.0
$ git checkout FETCH_HEAD
$ nix-build -A bazel

What's the output of git remote get-url origin ; git rev-parse master ; git rev-parse HEAD ?

non-applicable

Have you found anything relevant by searching the web?

nothing here in the issue tracker

@jin jin added team-Rules-Python Native rules for Python untriaged labels Jun 10, 2019
@brandjon brandjon added team-Remote-Exec Issues and PRs for the Execution (Remote) team and removed team-Rules-Python Native rules for Python labels Jun 10, 2019
@brandjon
Copy link
Member

This is not specific to Python. I'm able to reproduce it for sh_test. Note that this happens when you build a py_test but not when it's just a py_binary target.

@buchgr buchgr added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. and removed team-Remote-Exec Issues and PRs for the Execution (Remote) team labels Jun 11, 2019
@Profpatsch Profpatsch changed the title py_binary pulls in unnecessary java repositories at runtime (0.26) py_test/sh_test pulls in unnecessary java repositories at runtime (0.26) Jun 11, 2019
Profpatsch added a commit to groodt/nixpkgs that referenced this issue Jun 11, 2019
`py_test` tries to download unnecessary dependencies at runtime. We
can just as well run it to check the assertion.

Upstream issue: bazelbuild/bazel#8575
Profpatsch added a commit to groodt/nixpkgs that referenced this issue Jun 12, 2019
`py_test` tries to download unnecessary dependencies at runtime. We
can just as well run it to check the assertion.

Upstream issue: bazelbuild/bazel#8575
@laurentlb laurentlb added team-Rules-Java Issues for Java rules and removed team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. labels Jul 29, 2019
@iirina iirina added P2 We'll consider working on this in future. (Assignee optional) and removed untriaged labels Aug 21, 2019
@comius
Copy link
Contributor

comius commented Nov 21, 2020

The problem is that all Test rules depend on @bazel_tools//tools/test:coverage_report_generator, whether coverage is enabled or not.

@comius comius added P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed P2 We'll consider working on this in future. (Assignee optional) labels Feb 2, 2022
@sgowroji sgowroji added the stale Issues or PRs that are stale (no activity for 30 days) label Feb 16, 2023
@sgowroji
Copy link
Member

Hi there! We're doing a clean up of old issues and will be closing this one. Please reopen if you’d like to discuss anything further. We’ll respond as soon as we have the bandwidth/resources to do so.

@sgowroji sgowroji closed this as not planned Won't fix, can't repro, duplicate, stale Feb 16, 2023
@fmeum
Copy link
Collaborator

fmeum commented Feb 16, 2023

I believe this was fixed by #16995.

@sgowroji Could you close as completed?

@sgowroji sgowroji reopened this Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coverage P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Rules-Java Issues for Java rules type: bug
Projects
None yet
Development

No branches or pull requests

10 participants