Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve build speed by not registering ImportDepsChecker actions in aar_import when --experimental_import_deps_checker is "off" #8340

Closed
jin opened this issue May 15, 2019 · 1 comment
Closed

Improve build speed by not registering ImportDepsChecker actions in aar_import when --experimental_import_deps_checker is "off" #8340

jin opened this issue May 15, 2019 · 1 comment
Assignees
@jin
Labels
team-Android Issues for Android team untriaged

Comments

@jin
Copy link
Member

jin commented May 15, 2019 •
edited
Loading

Since import deps checker is off by default in Bazel, don't register the action and create the jdeps output. Only register it if the levels are warning or error.

Build profiles for https://github.com/google/google-authenticator-android on a 12 core linux machine:

With importdepschecker:

ss

Without importdepschecker:

ss

The more AARs there are, the larger the impact of this change is.
@jin jin added team-Android Issues for Android team untriaged labels May 15, 2019
@jin jin self-assigned this May 15, 2019
@jin
Copy link
Member Author

jin commented May 15, 2019

cc @ahumesky

This was referenced May 15, 2019
Closed
Closed
irengrig pushed a commit to irengrig/bazel that referenced this issue Jun 18, 2019
@jin @irengrig
Don't register import deps checker actions if --experimental_import_d…
a664be4 
…eps_checker is off

Fixes bazelbuild#8340

Closes bazelbuild#8341.

PiperOrigin-RevId: 248883983
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jin jin

Labels
team-Android Issues for Android team untriaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't register import deps checker actions if --experimental_import_deps_checker is off jin/bazel
1 participant
@jin