-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows: native test wrapper incorrectly escapes arguments [blocking #6622] #7956
Labels
area-Windows
Windows-specific issues and feature requests
P2
We'll consider working on this in future. (Assignee optional)
team-OSS
Issues for the Bazel OSS team: installation, release processBazel packaging, website
type: bug
Comments
laszlocsomor
added
P2
We'll consider working on this in future. (Assignee optional)
area-Windows
Windows-specific issues and feature requests
type: bug
labels
Apr 5, 2019
laszlocsomor
added a commit
to laszlocsomor/bazel
that referenced
this issue
Apr 5, 2019
The native test wrapper now correctly escapes the arguments for the subprocess, using bazel::launcher::WindowsEscapeArg2 from the native launcher. Fixes bazelbuild#7956 Unblocks bazelbuild#6622
dkelmer
pushed a commit
that referenced
this issue
Apr 11, 2019
The native test wrapper now correctly escapes the arguments for the subprocess, using bazel::launcher::WindowsEscapeArg2 from the native launcher. The test_wrapper_test now uses a mock C++ binary instead of a .bat file to verify the test arguments. Doing so trades the weird command line flag parsing logic of cmd.exe (inherent in using a .bat file) for the saner C++ flag parsing one. Fixes #7956 Unblocks #6622 Closes #7957. PiperOrigin-RevId: 242446422
dkelmer
pushed a commit
that referenced
this issue
Apr 16, 2019
The native test wrapper now correctly escapes the arguments for the subprocess, using bazel::launcher::WindowsEscapeArg2 from the native launcher. The test_wrapper_test now uses a mock C++ binary instead of a .bat file to verify the test arguments. Doing so trades the weird command line flag parsing logic of cmd.exe (inherent in using a .bat file) for the saner C++ flag parsing one. Fixes #7956 Unblocks #6622 Closes #7957. PiperOrigin-RevId: 242446422
dkelmer
pushed a commit
that referenced
this issue
Apr 25, 2019
The native test wrapper now correctly escapes the arguments for the subprocess, using bazel::launcher::WindowsEscapeArg2 from the native launcher. The test_wrapper_test now uses a mock C++ binary instead of a .bat file to verify the test arguments. Doing so trades the weird command line flag parsing logic of cmd.exe (inherent in using a .bat file) for the saner C++ flag parsing one. Fixes #7956 Unblocks #6622 Closes #7957. PiperOrigin-RevId: 242446422
dkelmer
pushed a commit
that referenced
this issue
Apr 25, 2019
The native test wrapper now correctly escapes the arguments for the subprocess, using bazel::launcher::WindowsEscapeArg2 from the native launcher. The test_wrapper_test now uses a mock C++ binary instead of a .bat file to verify the test arguments. Doing so trades the weird command line flag parsing logic of cmd.exe (inherent in using a .bat file) for the saner C++ flag parsing one. Fixes #7956 Unblocks #6622 Closes #7957. PiperOrigin-RevId: 242446422
dkelmer
pushed a commit
that referenced
this issue
Apr 25, 2019
The native test wrapper now correctly escapes the arguments for the subprocess, using bazel::launcher::WindowsEscapeArg2 from the native launcher. The test_wrapper_test now uses a mock C++ binary instead of a .bat file to verify the test arguments. Doing so trades the weird command line flag parsing logic of cmd.exe (inherent in using a .bat file) for the saner C++ flag parsing one. Fixes #7956 Unblocks #6622 Closes #7957. PiperOrigin-RevId: 242446422
dkelmer
pushed a commit
that referenced
this issue
Apr 26, 2019
The native test wrapper now correctly escapes the arguments for the subprocess, using bazel::launcher::WindowsEscapeArg2 from the native launcher. The test_wrapper_test now uses a mock C++ binary instead of a .bat file to verify the test arguments. Doing so trades the weird command line flag parsing logic of cmd.exe (inherent in using a .bat file) for the saner C++ flag parsing one. Fixes #7956 Unblocks #6622 Closes #7957. PiperOrigin-RevId: 242446422
dkelmer
pushed a commit
that referenced
this issue
Apr 29, 2019
The native test wrapper now correctly escapes the arguments for the subprocess, using bazel::launcher::WindowsEscapeArg2 from the native launcher. The test_wrapper_test now uses a mock C++ binary instead of a .bat file to verify the test arguments. Doing so trades the weird command line flag parsing logic of cmd.exe (inherent in using a .bat file) for the saner C++ flag parsing one. Fixes #7956 Unblocks #6622 Closes #7957. PiperOrigin-RevId: 242446422
philwo
added
the
team-OSS
Issues for the Bazel OSS team: installation, release processBazel packaging, website
label
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-Windows
Windows-specific issues and feature requests
P2
We'll consider working on this in future. (Assignee optional)
team-OSS
Issues for the Bazel OSS team: installation, release processBazel packaging, website
type: bug
Description of the problem / feature request:
The Windows-native test wrapper should escape arguments when running the test.
To escape them, it should use
bazel/src/tools/launcher/util/launcher_util.h
Line 61 in afeb8d0
Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
BUILD
:testargs.py
:Build Bazel from HEAD, e.g. afeb8d0.
Then use this binary:
The desired output is:
i.e.
c d
is one argument.What operating system are you running Bazel on?
windows 10
What's the output of
bazel info release
?I built bazel from HEAD (afeb8d0).
Any other information, logs, or outputs that you want to share?
This is blocking #6622
The text was updated successfully, but these errors were encountered: