Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incompatible_disallow_legacy_java_provider: Remove the old style, string-indexed Starlark ‘java’ provider #7598

Closed
iirina opened this issue Mar 1, 2019 · 13 comments
Closed

incompatible_disallow_legacy_java_provider: Remove the old style, string-indexed Starlark ‘java’ provider #7598

iirina opened this issue Mar 1, 2019 · 13 comments
Labels
incompatible-change Incompatible/breaking change team-Rules-Java Issues for Java rules

Comments

@iirina
Copy link
Contributor

iirina commented Mar 1, 2019

Flag: --incompatible_disallow_legacy_java_provider
Available since: 0.23 (February 2019 release)
Will be flipped in: 0.25 (April 2019 release)

The old style '.java' provider is removed in favor of JavaInfo.

Migration Notes

All Starlark usages of .java must be replaced by [JavaInfo].
@iirina iirina added incompatible-change Incompatible/breaking change breaking-change-0.25 labels Mar 1, 2019
@dslomov
Copy link
Contributor

dslomov commented Mar 1, 2019

Please follow the guidance at https://www.bazel.build/breaking-changes-guide.html

@lberki
Copy link
Contributor

lberki commented Mar 18, 2019

/cc @lberki

@lberki
Copy link
Contributor

lberki commented Mar 18, 2019

Can we put back the breaking-change-0.25 label now that the flag is released?

@iirina
Copy link
Contributor Author

iirina commented Mar 18, 2019

0.25 is not a realistic estimation anymore. 0.26 is safest.

@lberki
Copy link
Contributor

lberki commented Mar 18, 2019

Even thoug there are about six weeks until the April release is released?

@iirina
Copy link
Contributor Author

iirina commented Mar 18, 2019

There are only 2 weeks until the first RC is cut. Do we have a policy for cherry picking flipping incompatible flags?

@lberki
Copy link
Contributor

lberki commented Mar 18, 2019

Well, let's see who breaks... unfortunately, the migration-* label was missing, so CI run for this flag :(

@jin jin added the team-Rules-Server Issues for serverside rules included with Bazel label Mar 25, 2019
@dkelmer
Copy link
Contributor

dkelmer commented Apr 3, 2019

What is the status with this flag? 0.25 is being cut now. Do you want to leave breaking-change-0.26?

@dkelmer
Copy link
Contributor

dkelmer commented Apr 3, 2019

The instructions here say to remove the migration-ready label so I'm doing that

@jamiesnape jamiesnape mentioned this issue May 7, 2019
Merged
@dslomov
Copy link
Contributor

dslomov commented Jun 7, 2019

what is the status of this in 0.26?

@hlopko
Copy link
Member

hlopko commented Jun 7, 2019

Still not flipped. I updated labels now.

This was referenced Jun 20, 2019
Closed
Closed
ronshapiro pushed a commit to google/bazel-common that referenced this issue Jun 27, 2019
@rbeasley @ronshapiro
Support JavaInfo provider in javadoc_library
993b8f0 
Preparation for bazelbuild/bazel#7598.

Closes #75.
Resolves #76.

Testing Done:
- `./build_test.sh`
- Used `javadoc_library` in a project with custom Java rules which only export
  the `JavaInfo` provider.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=254235598
@ronshapiro ronshapiro mentioned this issue Jun 27, 2019
Merged
ronshapiro pushed a commit to google/bazel-common that referenced this issue Jun 27, 2019
@rbeasley @ronshapiro
Support JavaInfo provider in javadoc_library
4fb7798 
Preparation for bazelbuild/bazel#7598.

Closes #75.
Resolves #76.

Testing Done:
- `./build_test.sh`
- Used `javadoc_library` in a project with custom Java rules which only export
  the `JavaInfo` provider.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=254235598
@iirina iirina added team-Rules-Java Issues for Java rules and removed team-Rules-Server Issues for serverside rules included with Bazel labels Jul 8, 2019
@dslomov
Copy link
Contributor

dslomov commented Aug 5, 2019

Is there migration tooling available? What is the extent of the breakage?

This was referenced Aug 9, 2019
Merged
Closed
@iirina
Copy link
Contributor Author

iirina commented Aug 9, 2019

Gerrit code review sent in https://gerrit-review.googlesource.com/c/gerrit/+/233678.

This was referenced Aug 12, 2019
Closed
Closed
@iirina iirina mentioned this issue Aug 23, 2019
Closed
bazel-io pushed a commit that referenced this issue Aug 23, 2019
@iirina @copybara-github
Replace .java with JavaInfo provider.
900d8db 
Progress on #7598.

Closes #9230.

PiperOrigin-RevId: 265016605
cpovirk pushed a commit to google/flogger that referenced this issue Aug 26, 2019
@iirina @cpovirk
Upgrade bazel-common commit in floggers' WORKSPACE file.
6657862 
Preparation for bazelbuild/bazel#7598.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=265421674
@cpovirk cpovirk mentioned this issue Aug 26, 2019
Merged
cpovirk pushed a commit to google/flogger that referenced this issue Aug 26, 2019
@iirina @cpovirk
Upgrade bazel-common commit in floggers' WORKSPACE file.
477d892 
Preparation for bazelbuild/bazel#7598.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=265421674
bazel-io pushed a commit that referenced this issue Aug 28, 2019
@iirina @copybara-github
Prepare tests for flipping --incompatible_disallow_legacy_java_provider.
b774f65 
Progress on #7598.

RELNOTES: None.
PiperOrigin-RevId: 265874920
bazel-io pushed a commit that referenced this issue Aug 29, 2019
@iirina @copybara-github
Remove legacy JavaSkylarkApiProvider.
7acffaf 
--incompatible_disallow_legacy_java_provider (see #7598) is now a no-op and moved to the graveyard.

RELNOTES: None.
PiperOrigin-RevId: 266112979
@iirina iirina mentioned this issue Sep 2, 2019
Closed
bazel-io pushed a commit that referenced this issue Sep 3, 2019
@iirina @copybara-github
Remove all methods of legacy .java provider.
06fcb83 
--incompatible_disallow_legacy_java_provider (see #7598) is now a no-op and moved to the graveyard.

Fixes #9309.

RELNOTES: None.
PiperOrigin-RevId: 266919362
gnarled-cipher pushed a commit to gnarled-cipher/bazel that referenced this issue Sep 4, 2019
@iirina @gnarled-cipher
Remove all methods of legacy .java provider.
54921f0 
--incompatible_disallow_legacy_java_provider (see bazelbuild#7598) is now a no-op and moved to the graveyard.

Fixes bazelbuild#9309.

RELNOTES: None.
PiperOrigin-RevId: 266919362
This was referenced Sep 9, 2019
Closed
Merged
@laurentlb laurentlb mentioned this issue Sep 9, 2019
Closed
@davido davido mentioned this issue Sep 12, 2019
Closed
@jin jin mentioned this issue Sep 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
incompatible-change Incompatible/breaking change team-Rules-Java Issues for Java rules
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@katre @jin @hlopko @iirina @lberki @dslomov @dkelmer