Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Malformed Bazel output #6731

Closed
meteorcloudy opened this issue Nov 21, 2018 · 10 comments
Closed

Windows: Malformed Bazel output #6731

meteorcloudy opened this issue Nov 21, 2018 · 10 comments
Assignees
@laszlocsomor
Labels
area-Windows Windows-specific issues and feature requests P1 I'll work on this now. (Assignee required) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: bug

Comments

@meteorcloudy
Copy link
Member

meteorcloudy commented Nov 21, 2018 •
edited
Loading

TensorFlow recently reported a bug that they are no longer able to find error messages in Bazel's output log:
eg. https://source.cloud.google.com/results/invocations/9e5e78ac-152a-4ff8-aea0-2b587038a652/log

I can reproduce this bug by running the build of the following example on a CI Windows machine.
https://github.com/meteorcloudy/my_tests/tree/master/missing_log_test

Bisecting points 1a95502 as the culprit.

I also confirmed reverting 1a95502 from HEAD fixes the problem.

FYI @laszlocsomor @dslomov
@meteorcloudy meteorcloudy added type: bug P1 I'll work on this now. (Assignee required) release blocker area-Windows Windows-specific issues and feature requests labels Nov 21, 2018
@laszlocsomor
Copy link
Contributor

laszlocsomor commented Nov 21, 2018 •
edited
Loading

Is this a regression in 0.19.x over 0.18.0?

@laszlocsomor
Copy link
Contributor

I mean, do we have to make a patch release 0.19.3?

@meteorcloudy
Copy link
Member Author

Actually, this is a regression in 0.18.0 over 0.17.0...

@laszlocsomor
Copy link
Contributor

Sadly that means there were two minor versions with this bug.
Fortunately though, that means we don't have to create yet another 0.19.x patch release.

@meteorcloudy
Copy link
Member Author

meteorcloudy commented Nov 21, 2018 •
edited
Loading

I'm thinking about reverting 1a95502 first and cherry-pick it into 0.20.0. How does that sound? @dslomov

@laszlocsomor
Copy link
Contributor

Sounds good. Please do.

@laszlocsomor
Copy link
Contributor

And thank you so much for getting to the bottom of this error. From your explanations it sounded like a particularly difficult one to track down...

meteorcloudy added a commit to meteorcloudy/bazel that referenced this issue Nov 21, 2018
@meteorcloudy
Revert "WindowsFileSystem: open files with delete-sharing"
d9933e3 
This reverts commit 1a95502.

Related: bazelbuild#6731
@meteorcloudy meteorcloudy mentioned this issue Nov 21, 2018
Closed
@meteorcloudy
Copy link
Member Author

No problem! Glad we finally find it out! I can help test if you have a fix for this. ;)

bazel-io pushed a commit that referenced this issue Nov 27, 2018
@meteorcloudy
Revert "WindowsFileSystem: open files with delete-sharing"
d2920e3 
This reverts commit 1a95502.

Related: #6731

Closes #6732.

PiperOrigin-RevId: 222958770
@meteorcloudy
Copy link
Member Author

@dslomov Please cherry pick d2920e3 into 0.20.0 to fix this issue.

@meteorcloudy meteorcloudy mentioned this issue Nov 28, 2018
Closed
dslomov pushed a commit that referenced this issue Nov 28, 2018
@meteorcloudy @dslomov
Revert "WindowsFileSystem: open files with delete-sharing"
f3c6ce8 
This reverts commit 1a95502.

Related: #6731

Closes #6732.

PiperOrigin-RevId: 222958770
@meteorcloudy
Copy link
Member Author

This is resolved.

@meteorcloudy meteorcloudy mentioned this issue Dec 6, 2018
Closed
@laszlocsomor laszlocsomor mentioned this issue Oct 29, 2019
Closed
@philwo philwo added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Jun 15, 2020
luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this issue Sep 4, 2022
Revert "WindowsFileSystem: open files with delete-sharing"
d797e92 
    This reverts commit 1a955020ff7a27b9d49c83aef89e0991380daa5e.

    Related: bazelbuild/bazel#6731

    Closes #6732.

    PiperOrigin-RevId: 222958770
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laszlocsomor laszlocsomor

Labels
area-Windows Windows-specific issues and feature requests P1 I'll work on this now. (Assignee required) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@philwo @meteorcloudy @laszlocsomor