Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "deps" attribute to cc_import #5456

Closed
pylaligand opened this issue Jun 23, 2018 · 2 comments
Closed

Add a "deps" attribute to cc_import #5456

pylaligand opened this issue Jun 23, 2018 · 2 comments
Assignees
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Rules-CPP Issues for C++ rules type: feature request

Comments

@pylaligand
Copy link

Description of the problem / feature request:

This is a feature request to add a deps attribute to cc_import.

Feature requests: what underlying problem are you trying to solve with this feature?

Some prebuilt libraries have public dependencies on other libraries, by using these libraries' public headers in their own public headers. There currently does not seem to be a way to express this with cc_import which is the preferred way to include prebuilts.

Have you found anything relevant by searching the web?

There's a way to work around this by declaring a cc_library which both depends on the cc_import and on its public dependencies, and direct clients to depend on the cc_library.

@hlopko hlopko added the P2 We'll consider working on this in future. (Assignee optional) label Jun 25, 2018
@hlopko hlopko assigned oquenchil and unassigned hlopko Jun 25, 2018
@hlopko
Copy link
Member

hlopko commented Jun 25, 2018

Good point, we'll fix it. But to save cycles let's do so only after cc_import is in Skylark (blocked by #4570).

@hlopko hlopko added team-Rules-CPP Issues for C++ rules and removed category: rules > C++ labels Oct 11, 2018
@agluszak agluszak self-assigned this Jul 23, 2020
ehkloaj pushed a commit to ehkloaj/bazel that referenced this issue Aug 6, 2020
@MSK61
Copy link

MSK61 commented Mar 9, 2023

The attribute is still not documented here though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Rules-CPP Issues for C++ rules type: feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants