Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom stub template for java_binary #3451

Open
hhclam opened this issue Jul 26, 2017 · 7 comments
Open

Allow custom stub template for java_binary #3451

hhclam opened this issue Jul 26, 2017 · 7 comments
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Rules-Java Issues for Java rules type: feature request

Comments

@hhclam
Copy link
Contributor

hhclam commented Jul 26, 2017

Description of the feature request:

We would like to use our own java stub template to replace java_stub_template.txt. Our use case uses a lot of custom system properties that can be generated from rule dependencies. However Bazel's java stub template is fixed. It would be nice to allow custom java rule template through something like java_toolchain

@petroseskinder
Copy link
Member

@cushon, any thoughts on this feature request seeing as how the python rules are exploring this via bazelbuild/rules_python#130

@ittaiz
Copy link
Member

ittaiz commented Nov 14, 2018 via email

@cushon cushon added team-Rules-Java Issues for Java rules and removed category: rules > java labels Nov 14, 2018
@cushon
Copy link
Contributor

cushon commented Nov 14, 2018

This would also make it easier to iterate on the stub script, since currently you have to re-build Bazel to pick up changes.

@lberki we talked about something like this once, and you noted it "would require making the set of %{} template variables and the template language itself part of the interface of Bazel."

@comius comius added the P3 We're not considering working on this, but happy to review a PR. (No assignee) label Nov 20, 2020
@sgowroji sgowroji added the stale Issues or PRs that are stale (no activity for 30 days) label Feb 17, 2023
@sgowroji
Copy link
Member

Hi there! We're doing a clean up of old issues and will be closing this one. Please reopen (or ping me to reopen) if you’d like to discuss anything further. We’ll respond as soon as we have the bandwidth/resources to do so.

@sgowroji sgowroji closed this as not planned Won't fix, can't repro, duplicate, stale Feb 17, 2023
@ittaiz
Copy link
Member

ittaiz commented Feb 17, 2023

Note- lack of this feature means forking bazel or "only" the Java rules

@sgowroji sgowroji removed the stale Issues or PRs that are stale (no activity for 30 days) label Feb 17, 2023
@sgowroji sgowroji reopened this Feb 17, 2023
Copy link

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 90 days unless any other activity occurs. If you think this issue is still relevant and should stay open, please post any comment here and the issue will no longer be marked as stale.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Apr 23, 2024
@ittaiz
Copy link
Member

ittaiz commented Apr 23, 2024

Still very relevant. Please don't close.

@github-actions github-actions bot removed the stale Issues or PRs that are stale (no activity for 30 days) label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Rules-Java Issues for Java rules type: feature request
Projects
None yet
Development

No branches or pull requests

7 participants