Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0.0] Remove Protobuf rules #24176

Closed
comius opened this issue Nov 4, 2024 · 2 comments
Closed

[8.0.0] Remove Protobuf rules #24176

comius opened this issue Nov 4, 2024 · 2 comments
Assignees
@comius
Labels
team-Rules-API API for writing rules/aspects: providers, runfiles, actions, artifacts type: bug
Milestone
8.0.0 release blo...

Comments

@comius
Copy link
Contributor

comius commented Nov 4, 2024 •
edited
Loading

Description of the bug:

Having 2 copies of rules in Bazel and in Protobuf repository is potentially problematic.

Which category does this issue belong to?

Rules API
@comius comius added this to the 8.0.0 release blockers milestone Nov 4, 2024
@github-actions github-actions bot added the team-Rules-API API for writing rules/aspects: providers, runfiles, actions, artifacts label Nov 4, 2024
@comius comius assigned comius and unassigned sgowroji, iancha1992 and satyanandak Nov 4, 2024
@comius comius removed the untriaged label Nov 4, 2024
@comius
Copy link
Contributor Author

comius commented Nov 4, 2024

Already done, needs to be cherry-picked.

@comius comius mentioned this issue Nov 5, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 6, 2024
@comius
[8.0.0] Remove Proto rules (#24215)
f25551b 
Fixes: #24176

Cherry-picks:
b3ba592
e63c615
86c8b0f
db22635
5381f6b
f1e796e
@iancha1992
Copy link
Member

Cherry-picked in #24215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@comius comius

Labels
team-Rules-API API for writing rules/aspects: providers, runfiles, actions, artifacts type: bug
Projects
None yet
Milestone
8.0.0 release blockers
Development

No branches or pull requests
4 participants
@comius @sgowroji @iancha1992 @satyanandak