Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.2.1] Enforce and await cleanup in StarlarkBaseExternalContext #22775

Closed
bazel-io opened this issue Jun 18, 2024 · 3 comments
Closed

[7.2.1] Enforce and await cleanup in StarlarkBaseExternalContext #22775

bazel-io opened this issue Jun 18, 2024 · 3 comments
Milestone
7.2.1 release blo...

Comments

@bazel-io
Copy link
Member

Forked from #22772
@bazel-io bazel-io added this to the 7.2.1 release blockers milestone Jun 18, 2024
@meteorcloudy meteorcloudy mentioned this issue Jun 19, 2024
Closed
@bazel-io
Copy link
Member Author

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/java/com/google/devtools/build/lib/bazel/bzlmod/SingleExtensionEvalFunction.java
src/main/java/com/google/devtools/build/lib/bazel/repository/starlark/StarlarkRepositoryFunction.java

cc: @bazelbuild/triage

@meteorcloudy
Copy link
Member

@fmeum Can you help with this one?

@fmeum
Copy link
Collaborator

fmeum commented Jun 20, 2024

@meteorcloudy I sent #22814

@fmeum fmeum mentioned this issue Jun 20, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 20, 2024
@fmeum
[7.2.1] Enforce and await cleanup in StarlarkBaseExternalContext (#…
8fb4dce 
…22814)

`StarlarkBaseExternalContext` now implements `AutoCloseable` and, in
`close()`:
1. Cancels all pending async tasks.
2. Awaits their termination.
3. Cleans up the working directory (always for module extensions, on
failure for repo rules).
4. Fails if there were pending async tasks in an otherwise successful
evaluation.

Previously, module extensions didn't do any of those. Repo rules did 1
and 4 and sometimes 3, but not in all cases.

This change required replacing the fixed-size thread pool in
`DownloadManager` with virtual threads, thereby resolving a TODO about
not using a fixed-size thread pool for the `GrpcRemoteDownloader`.

Work towards #22680
Work towards #22748

Closes #22772

PiperOrigin-RevId: 644669599
Change-Id: Ib71e5bf346830b92277ac2bd473e11c834cb2624

Closes #22775
@keertk keertk mentioned this issue Jun 20, 2024
Merged
fmeum added a commit to fmeum/bazel that referenced this issue Jul 18, 2024
@fmeum
[7.2.1] Enforce and await cleanup in StarlarkBaseExternalContext (b…
16e0a84 
…azelbuild#22814)

`StarlarkBaseExternalContext` now implements `AutoCloseable` and, in
`close()`:
1. Cancels all pending async tasks.
2. Awaits their termination.
3. Cleans up the working directory (always for module extensions, on
failure for repo rules).
4. Fails if there were pending async tasks in an otherwise successful
evaluation.

Previously, module extensions didn't do any of those. Repo rules did 1
and 4 and sometimes 3, but not in all cases.

This change required replacing the fixed-size thread pool in
`DownloadManager` with virtual threads, thereby resolving a TODO about
not using a fixed-size thread pool for the `GrpcRemoteDownloader`.

Work towards bazelbuild#22680
Work towards bazelbuild#22748

Closes bazelbuild#22772

PiperOrigin-RevId: 644669599
Change-Id: Ib71e5bf346830b92277ac2bd473e11c834cb2624

Closes bazelbuild#22775
oliviernotteghem pushed a commit to uber-common/bazel that referenced this issue Aug 13, 2024
@fmeum @oliviernotteghem
[7.2.1] Enforce and await cleanup in StarlarkBaseExternalContext (b…
0e1b8aa 
…azelbuild#22814)

`StarlarkBaseExternalContext` now implements `AutoCloseable` and, in
`close()`:
1. Cancels all pending async tasks.
2. Awaits their termination.
3. Cleans up the working directory (always for module extensions, on
failure for repo rules).
4. Fails if there were pending async tasks in an otherwise successful
evaluation.

Previously, module extensions didn't do any of those. Repo rules did 1
and 4 and sometimes 3, but not in all cases.

This change required replacing the fixed-size thread pool in
`DownloadManager` with virtual threads, thereby resolving a TODO about
not using a fixed-size thread pool for the `GrpcRemoteDownloader`.

Work towards bazelbuild#22680
Work towards bazelbuild#22748

Closes bazelbuild#22772

PiperOrigin-RevId: 644669599
Change-Id: Ib71e5bf346830b92277ac2bd473e11c834cb2624

Closes bazelbuild#22775
oliviernotteghem pushed a commit to uber-common/bazel that referenced this issue Dec 4, 2024
@fmeum @oliviernotteghem
[7.2.1] Enforce and await cleanup in StarlarkBaseExternalContext (b…
bdac596 
…azelbuild#22814)

`StarlarkBaseExternalContext` now implements `AutoCloseable` and, in
`close()`:
1. Cancels all pending async tasks.
2. Awaits their termination.
3. Cleans up the working directory (always for module extensions, on
failure for repo rules).
4. Fails if there were pending async tasks in an otherwise successful
evaluation.

Previously, module extensions didn't do any of those. Repo rules did 1
and 4 and sometimes 3, but not in all cases.

This change required replacing the fixed-size thread pool in
`DownloadManager` with virtual threads, thereby resolving a TODO about
not using a fixed-size thread pool for the `GrpcRemoteDownloader`.

Work towards bazelbuild#22680
Work towards bazelbuild#22748

Closes bazelbuild#22772

PiperOrigin-RevId: 644669599
Change-Id: Ib71e5bf346830b92277ac2bd473e11c834cb2624

Closes bazelbuild#22775
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.2.1 release blockers
Development

No branches or pull requests
4 participants
@meteorcloudy @fmeum @bazel-io @iancha1992