-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.1.0] Unable to detect AndroidIdeInfo #21544
Comments
@bazel-io fork 7.1.0 |
Is work happening on this right now? Does it need to block the 7.1.0 release? |
Internal PR is in review. I'd prefer to have it in the release, so that legacy struct providers cleanup is not further blocked. |
We expect to cut rc2 today, is this going to be fixed in time? |
Previously 916c3f5 exposed the provider on top-level to support IntelliJ aspects. Exposing it over android_common, makes it possible to detect its presence in Starlark code via `getattr(android_common, "AndroidIdeInfo")`. With this detection it's easier to support older Bazel versions. Without exposing it via android_common, detecting AndroidIdeInfo presence in Bazel world is only possible using a new dependency on @bazel_features in IntelliJ aspects. Addresses: #21544 PiperOrigin-RevId: 613580552 Change-Id: I214024facbdc9ac7742bf98575101bd624d4a6a7
Previously bazelbuild@916c3f5 exposed the provider on top-level to support IntelliJ aspects. Exposing it over android_common, makes it possible to detect its presence in Starlark code via `getattr(android_common, "AndroidIdeInfo")`. With this detection it's easier to support older Bazel versions. Without exposing it via android_common, detecting AndroidIdeInfo presence in Bazel world is only possible using a new dependency on @bazel_features in IntelliJ aspects. Addresses: bazelbuild#21544 PiperOrigin-RevId: 613580552 Change-Id: I214024facbdc9ac7742bf98575101bd624d4a6a7
Previously 916c3f5 exposed the provider on top-level to support IntelliJ aspects. Exposing it over android_common, makes it possible to detect its presence in Starlark code via `getattr(android_common, "AndroidIdeInfo")`. With this detection it's easier to support older Bazel versions. Without exposing it via android_common, detecting AndroidIdeInfo presence in Bazel world is only possible using a new dependency on @bazel_features in IntelliJ aspects. Fixes: #21544 PiperOrigin-RevId: 613580552 Change-Id: I214024facbdc9ac7742bf98575101bd624d4a6a7
Fixed in #21607 |
A fix for this issue has been included in Bazel 7.1.0 RC2. Please test out the release candidate and report any issues as soon as possible. |
Description of the bug:
With AndroidIdeInfo exposed on top-level, it's hard to detect it in IntelliJ plugin, considering the plugin works on different Bazel versions.
Which category does this issue belong to?
Android
What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
No response
Which operating system are you running Bazel on?
No response
What is the output of
bazel info release
?No response
If
bazel info release
returnsdevelopment version
or(@non-git)
, tell us how you built Bazel.No response
What's the output of
git remote get-url origin; git rev-parse HEAD
?No response
Is this a regression? If yes, please try to identify the Bazel commit where the bug was introduced.
No response
Have you found anything relevant by searching the web?
No response
Any other information, logs, or outputs that you want to share?
No response
The text was updated successfully, but these errors were encountered: