Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.1.0] Unable to detect AndroidIdeInfo #21544

Closed
comius opened this issue Mar 4, 2024 · 6 comments
Closed

[7.1.0] Unable to detect AndroidIdeInfo #21544

comius opened this issue Mar 4, 2024 · 6 comments
Assignees
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Android Issues for Android team type: bug

Comments

@comius
Copy link
Contributor

comius commented Mar 4, 2024

Description of the bug:

With AndroidIdeInfo exposed on top-level, it's hard to detect it in IntelliJ plugin, considering the plugin works on different Bazel versions.

Which category does this issue belong to?

Android

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

No response

Which operating system are you running Bazel on?

No response

What is the output of bazel info release?

No response

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse HEAD ?

No response

Is this a regression? If yes, please try to identify the Bazel commit where the bug was introduced.

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@comius comius added this to the 7.1.0 release blockers milestone Mar 4, 2024
@comius comius added team-Android Issues for Android team and removed untriaged labels Mar 4, 2024
@comius comius added P2 We'll consider working on this in future. (Assignee optional) and removed untriaged labels Mar 4, 2024
@comius comius assigned comius, sgowroji and iancha1992 and unassigned sgowroji and iancha1992 Mar 4, 2024
@keertk
Copy link
Member

keertk commented Mar 4, 2024

@bazel-io fork 7.1.0

@Wyverald
Copy link
Member

Wyverald commented Mar 5, 2024

Is work happening on this right now? Does it need to block the 7.1.0 release?

@comius
Copy link
Contributor Author

comius commented Mar 6, 2024

Is work happening on this right now? Does it need to block the 7.1.0 release?

Internal PR is in review. I'd prefer to have it in the release, so that legacy struct providers cleanup is not further blocked.

@meteorcloudy
Copy link
Member

We expect to cut rc2 today, is this going to be fixed in time?

copybara-service bot pushed a commit that referenced this issue Mar 7, 2024
Previously 916c3f5 exposed the provider on top-level to support IntelliJ aspects. Exposing it over android_common, makes it possible to detect its presence in Starlark code via `getattr(android_common, "AndroidIdeInfo")`. With this detection it's easier to support older Bazel versions.

Without exposing it via android_common, detecting AndroidIdeInfo presence in Bazel world is only possible using a new dependency on @bazel_features in IntelliJ aspects.

Addresses: #21544
PiperOrigin-RevId: 613580552
Change-Id: I214024facbdc9ac7742bf98575101bd624d4a6a7
comius added a commit to comius/bazel that referenced this issue Mar 7, 2024
Previously bazelbuild@916c3f5 exposed the provider on top-level to support IntelliJ aspects. Exposing it over android_common, makes it possible to detect its presence in Starlark code via `getattr(android_common, "AndroidIdeInfo")`. With this detection it's easier to support older Bazel versions.

Without exposing it via android_common, detecting AndroidIdeInfo presence in Bazel world is only possible using a new dependency on @bazel_features in IntelliJ aspects.

Addresses: bazelbuild#21544
PiperOrigin-RevId: 613580552
Change-Id: I214024facbdc9ac7742bf98575101bd624d4a6a7
github-merge-queue bot pushed a commit that referenced this issue Mar 7, 2024
Previously
916c3f5
exposed the provider on top-level to support IntelliJ aspects. Exposing
it over android_common, makes it possible to detect its presence in
Starlark code via `getattr(android_common, "AndroidIdeInfo")`. With this
detection it's easier to support older Bazel versions.

Without exposing it via android_common, detecting AndroidIdeInfo
presence in Bazel world is only possible using a new dependency on
@bazel_features in IntelliJ aspects.

Fixes: #21544
PiperOrigin-RevId: 613580552
Change-Id: I214024facbdc9ac7742bf98575101bd624d4a6a7
@iancha1992
Copy link
Member

Fixed in #21607

@iancha1992
Copy link
Member

A fix for this issue has been included in Bazel 7.1.0 RC2. Please test out the release candidate and report any issues as soon as possible.
If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=7.1.0rc2. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Android Issues for Android team type: bug
Projects
None yet
Development

No branches or pull requests

6 participants