Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick proto toolchainsation PRs #20921

Closed
comius opened this issue Jan 17, 2024 · 2 comments
Closed

Cherry-pick proto toolchainsation PRs #20921

comius opened this issue Jan 17, 2024 · 2 comments
Assignees
@comius
Milestone
6.5.0 release blo...

Comments

@comius
Copy link
Contributor

comius commented Jan 17, 2024

Commit IDs

TODO

Category

team-Rules-API

Reviewers

@iancha1992
@comius comius added this to the 6.5.0 release blockers milestone Jan 17, 2024
@comius comius self-assigned this Jan 17, 2024
@bazel-io
Copy link
Member

Failed commmits (likely due to merge conflicts): TODO.
Please resolve manually.
cc: @bazelbuild/triage

@iancha1992
Copy link
Member

iancha1992 commented Jan 17, 2024 •
edited
Loading

Just a friendly reminder to make sure to milestone it again to trigger the cherry-pick bot. It will only be triggered when milestoned. Thanks!

@comius comius mentioned this issue Jan 17, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 18, 2024
@comius
[6.5.0] Proto toolchainisation cherrypicks (#20925)
d2daa9b 
Fixes: #20921

List of cherrypicks:
5a24c8a [email protected] Mon Oct 9 02:27:10 2023 -0700 Support
automatic exec groups in proto_common.compile
3e1e061 [email protected] Tue Oct 3 03:32:01 2023 -0700 Use proto
toolchains in cc_proto_library
8c38be3 [email protected] Mon Oct 2 07:08:55 2023 -0700 Use proto
toolchains in java_lite_proto_library
51970d2 [email protected] Mon Oct 2 07:05:16 2023 -0700 Use proto
toolchains in java_proto_library
20bc11f [email protected] Mon Oct 2 06:56:47 2023 -0700 Decouple
java_lite_proto_library from java_proto_library
3b18d3f [email protected] Mon Oct 2 04:11:24 2023 -0700 Refactor proto
toolchainsation support utilities
42800a8 [email protected] Fri Sep 22 03:04:18 2023 -0700 Use proto
compiler from proto_toolchain rule
d435c6d [email protected] Thu Sep 21 07:05:40 2023 -0700 Use
proto_toolchain in proto_library
f5fb2f6 [email protected] Wed Sep 20 05:50:59 2023 -0700 Remove protoc
from proto_lang_toolchain rule
108ef55 [email protected] Tue Sep 19 08:40:00 2023 -0700 Use
MockProtoSupport.setup where protos are used
11cf1b7 [email protected] Sun Sep 17 21:57:54 2023 -0700 Implement
incompatible_enable_proto_toolchain_resolution
@keertk keertk closed this as completed Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@comius comius

Labels
None yet
Projects
None yet
Milestone
6.5.0 release blockers
Development

No branches or pull requests
4 participants
@comius @bazel-io @keertk @iancha1992