Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.5.0] Java --add-opens should not be passed to javac; breaks with -Werror #20468

Closed
bazel-io opened this issue Dec 7, 2023 · 2 comments
Closed

[6.5.0] Java --add-opens should not be passed to javac; breaks with -Werror #20468

bazel-io opened this issue Dec 7, 2023 · 2 comments
Milestone
6.5.0 release blo...

Comments

@bazel-io
Copy link
Member

bazel-io commented Dec 7, 2023

Forked from #19876
@bazel-io bazel-io added this to the 6.5.0 release blockers milestone Dec 7, 2023
@iancha1992
Copy link
Member

@hvadehra @cushon @Wyverald @meteorcloudy
I cannot cherry-pick this (367994a) to release-6.5.0 because src/main/starlark/builtins_bzl/common/java/java_common_internal_for_builtins.bzl is missing in the branch.

cc: @bazelbuild/triage

hvadehra added a commit that referenced this issue Dec 8, 2023
@hvadehra
Don't pass --add-opens= to javac
c63d027 
Backported from 367994a

Fixes #20468
@hvadehra hvadehra mentioned this issue Dec 8, 2023
Merged
@iancha1992
Copy link
Member

iancha1992 commented Dec 8, 2023 •
edited
Loading

Cherry-picked in #20472 by @hvadehra. Thanks

Wyverald pushed a commit that referenced this issue Dec 11, 2023
@hvadehra
[6.5.0] Don't pass --add-opens= to javac (#20472)
5fccef1 
Backported from
367994a

Fixes #20468
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.5.0 release blockers
Development

No branches or pull requests
3 participants
@Wyverald @bazel-io @iancha1992