Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.4.0] Fix handling of non-ASCII characters in archive entry file names #19671

Closed
bazel-io opened this issue Sep 28, 2023 · 2 comments
Closed

[6.4.0] Fix handling of non-ASCII characters in archive entry file names #19671

bazel-io opened this issue Sep 28, 2023 · 2 comments
Milestone
6.4.0 release blo...

Comments

@bazel-io
Copy link
Member

Forked from #18448
@bazel-io bazel-io added this to the 6.4.0 release blockers milestone Sep 28, 2023
@bazel-io
Copy link
Member Author

bazel-io commented Oct 9, 2023

Cherry-pick was attempted, but there may be merge conflict(s). Please resolve manually.
cc: @bazelbuild/triage

@fmeum fmeum mentioned this issue Oct 9, 2023
Merged
@fmeum
Copy link
Collaborator

fmeum commented Oct 9, 2023

Manual cherry-pick in #19765

meteorcloudy pushed a commit that referenced this issue Oct 9, 2023
@fmeum
[6.4.0] Fix handling of non-ASCII characters in archive entry file na…
b90ab8b 
…mes (#19765)

When creating a `PathFragment` from a ZIP or TAR entry file name, the
raw bytes of the name are now wrapped into a Latin-1 encoded String,
which is how Bazel internally represents file paths.

Previously, ZIP entries as well as TAR entries with PAX headers would
result in ordinary decoded Java strings, resulting in corrupted file
names when passed to Bazel's file system operations.

Fixes #12986

Fixes bazel-contrib/rules_go#2771

Closes #18448.

PiperOrigin-RevId: 571857847
Change-Id: Ie578724e75ddbefbe05255601b0afab706835f89

Fixes #19671
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.4.0 release blockers
Development

No branches or pull requests
3 participants
@meteorcloudy @fmeum @bazel-io