Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--legacy_bazel_java_test turn down #17758

Closed
hvadehra opened this issue Mar 13, 2023 · 0 comments
Closed

--legacy_bazel_java_test turn down #17758

hvadehra opened this issue Mar 13, 2023 · 0 comments
Assignees
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Rules-Java Issues for Java rules

Comments

@hvadehra
Copy link
Member

With the migration of java_test to Starlark, the --legacy_bazel_java_test flag will become a no-op, and will be subsequently deleted.

The idea is to resolve #2539 by enhancing the test runner and java_test, but the plan is to do that once we have a single, final implementation of the java_test rule (i.e. in Starlark).

@hvadehra hvadehra added P2 We'll consider working on this in future. (Assignee optional) team-Rules-Java Issues for Java rules labels Mar 13, 2023
@hvadehra hvadehra self-assigned this Mar 13, 2023
copybara-service bot pushed a commit that referenced this issue Mar 14, 2023
This makes `--legacy_bazel_java_test` a no-op:   #17758

RELNOTES[INC]: --legacy_bazel_java_test is now a no-op

PiperOrigin-RevId: 516540643
Change-Id: If37fac1f6dab1659975c3a17fc3151e365a72b65
copybara-service bot pushed a commit that referenced this issue Mar 15, 2023
*** Reason for rollback ***

Breakages in downstream

*** Original change description ***

Enable Starlark `java_test` in Bazel

This makes `--legacy_bazel_java_test` a no-op:   #17758

RELNOTES[INC]: --legacy_bazel_java_test is now a no-op

PiperOrigin-RevId: 516952453
Change-Id: I30a5177954747060133209461c080071d9c1fd84
copybara-service bot pushed a commit that referenced this issue Mar 20, 2023
Breakages have been fixed and downstream CI no longer has new breakages

*** Original change description ***

Automated rollback of commit 08d3187.

*** Reason for rollback ***

Breakages in downstream

*** Original change description ***

Enable Starlark `java_test` in Bazel

This makes `--legacy_bazel_java_test` a no-op:   #17758

RELNOTES[INC]: --legacy_bazel_java_test is now a no-op

PiperOrigin-RevId: 517997743
Change-Id: I73d5a2adc0d505ea69d41f92d7f9f0b247a19b2b
fweikert pushed a commit that referenced this issue Mar 27, 2023
*** Reason for rollback ***

Breakages in downstream

*** Original change description ***

Enable Starlark `java_test` in Bazel

This makes `--legacy_bazel_java_test` a no-op:   #17758

RELNOTES[INC]: --legacy_bazel_java_test is now a no-op

PiperOrigin-RevId: 516952453
Change-Id: I30a5177954747060133209461c080071d9c1fd84
fweikert pushed a commit to fweikert/bazel that referenced this issue May 25, 2023
This makes `--legacy_bazel_java_test` a no-op:   bazelbuild#17758

RELNOTES[INC]: --legacy_bazel_java_test is now a no-op

PiperOrigin-RevId: 516540643
Change-Id: If37fac1f6dab1659975c3a17fc3151e365a72b65
fweikert pushed a commit to fweikert/bazel that referenced this issue May 25, 2023
*** Reason for rollback ***

Breakages in downstream

*** Original change description ***

Enable Starlark `java_test` in Bazel

This makes `--legacy_bazel_java_test` a no-op:   bazelbuild#17758

RELNOTES[INC]: --legacy_bazel_java_test is now a no-op

PiperOrigin-RevId: 516952453
Change-Id: I30a5177954747060133209461c080071d9c1fd84
fweikert pushed a commit to fweikert/bazel that referenced this issue May 25, 2023
Breakages have been fixed and downstream CI no longer has new breakages

*** Original change description ***

Automated rollback of commit 08d3187.

*** Reason for rollback ***

Breakages in downstream

*** Original change description ***

Enable Starlark `java_test` in Bazel

This makes `--legacy_bazel_java_test` a no-op:   bazelbuild#17758

RELNOTES[INC]: --legacy_bazel_java_test is now a no-op

PiperOrigin-RevId: 517997743
Change-Id: I73d5a2adc0d505ea69d41f92d7f9f0b247a19b2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Rules-Java Issues for Java rules
Projects
None yet
Development

No branches or pull requests

1 participant