Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bazel's git_repository and new_git_repository is not compatible with the latest Git version #17040

Closed
meteorcloudy opened this issue Dec 16, 2022 · 2 comments
Closed

Bazel's git_repository and new_git_repository is not compatible with the latest Git version #17040

meteorcloudy opened this issue Dec 16, 2022 · 2 comments
Assignees
@meteorcloudy
Labels
P1 I'll work on this now. (Assignee required) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: bug

Comments

@meteorcloudy
Copy link
Member

The git version on Bazel CI's Windows VMs has just been upgraded, and some integration tests for git_repository/new_git_repository is failing:
https://storage.googleapis.com/bazel-untrusted-buildkite-artifacts/01851af9-6e76-4a64-9f5f-4abd2a74d22d/src%5Ctest%5Cshell%5Cbazel%5Cgit_repository_test%5Ctest_attempts%5Cattempt_1.log

Error in fail: error running 'git submodule update --init --checkout --force' while working with @outer_planets:
Submodule 'pluto' (C:/b/2uczrvoj/execroot/io_bazel/_tmp/ed1461f2c2fd61eb714263949496bed9/repos/pluto) registered for path 'pluto'
Cloning into 'C:/b/2uczrvoj/execroot/io_bazel/_tmp/ed1461f2c2fd61eb714263949496bed9/root/zqbtua63/external/outer_planets/pluto'...
fatal: transport 'file' not allowed

Root cause is this Git update: https://lore.kernel.org/lkml/[email protected]/, but we need to somehow fix those integration tests and git_repository/new_git_repository rules.
@meteorcloudy meteorcloudy added type: bug P1 I'll work on this now. (Assignee required) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. labels Dec 16, 2022
@meteorcloudy meteorcloudy self-assigned this Dec 16, 2022
copybara-service bot pushed a commit that referenced this issue Dec 16, 2022
@meteorcloudy @copybara-github
Disable a test case in git_repository_test.sh on Windows
aed6522 
Due to #17040

PiperOrigin-RevId: 495854505
Change-Id: I90d8d537e87f7ea51fa79b2847997c280baccf7f
copybara-service bot pushed a commit that referenced this issue Dec 16, 2022
@meteorcloudy @copybara-github
Disable test_new_git_repository_submodules in starlark_git_repository…
74f66e5 
…_test

Due to #17040

PiperOrigin-RevId: 495878182
Change-Id: I69107cfd1bbc2468e62ac9804ca4a18fda87fa1b
@fweikert fweikert mentioned this issue Dec 23, 2022
Closed
5 tasks
@meteorcloudy
Copy link
Member Author

Fixes are explained at https://vielmetti.typepad.com/logbook/2022/10/git-security-fixes-lead-to-fatal-transport-file-not-allowed-error-in-ci-systems-cve-2022-39253.html

@Wyverald
Copy link
Member

@bazel-io fork 6.1.0

@bazel-io bazel-io mentioned this issue Jan 18, 2023
Closed
@ShreeM01 ShreeM01 mentioned this issue Jan 18, 2023
Merged
meteorcloudy added a commit that referenced this issue Jan 19, 2023
@ShreeM01 @meteorcloudy
Enable git_submodules tests and merge git_repository and starlark_git…
c2bfb2e 
…_repository (#17247)

- Added necessary flags to allow clone submodule from local repository.
- We only have the starlark version of git repository rule and most test cases in two integration tests are duplicated.

Fixes #17040

RELNOTES: None
PiperOrigin-RevId: 498989149
Change-Id: I1eec3efa17382ddd0a608c0984e2f6c9f29c5c7c

Co-authored-by: Googler <[email protected]>
hvadehra pushed a commit that referenced this issue Feb 14, 2023
@meteorcloudy @hvadehra
Disable a test case in git_repository_test.sh on Windows
3fd04cf 
Due to #17040

PiperOrigin-RevId: 495854505
Change-Id: I90d8d537e87f7ea51fa79b2847997c280baccf7f
hvadehra pushed a commit that referenced this issue Feb 14, 2023
@meteorcloudy @hvadehra
Disable test_new_git_repository_submodules in starlark_git_repository…
9c3dda3 
…_test

Due to #17040

PiperOrigin-RevId: 495878182
Change-Id: I69107cfd1bbc2468e62ac9804ca4a18fda87fa1b
hvadehra pushed a commit that referenced this issue Feb 14, 2023
@meteorcloudy @hvadehra
Enable git_submodules tests and merge git_repository and starlark_git…
ec0452c 
…_repository

- Added necessary flags to allow clone submodule from local repository.
- We only have the starlark version of git repository rule and most test cases in two integration tests are duplicated.

Fixes #17040

RELNOTES: None
PiperOrigin-RevId: 498989149
Change-Id: I1eec3efa17382ddd0a608c0984e2f6c9f29c5c7c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meteorcloudy meteorcloudy

Labels
P1 I'll work on this now. (Assignee required) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Wyverald @meteorcloudy