Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using absl flags in python based helpers #16882

Closed
2 of 13 tasks
aiuto opened this issue Nov 29, 2022 · 6 comments
Closed
2 of 13 tasks

Stop using absl flags in python based helpers #16882

aiuto opened this issue Nov 29, 2022 · 6 comments
Labels
stale Issues or PRs that are stale (no activity for 30 days) type: process

Comments

@aiuto
Copy link
Contributor

aiuto commented Nov 29, 2022 •
edited
Loading

Technical debt

We depend on absl flags instead of argparse in many android helpers.
We could switch to argparse to reduce footprint.

  • tools/build_defs/pkg/build_tar.py
  • tools/android/incremental_install.py
  • tools/android/strip_resources.py
  • tools/android/instrumentation_test_check.py
  • tools/android/aar_embedded_jars_extractor.py
  • tools/android/aar_resources_extractor.py
  • tools/android/aar_embedded_proguard_extractor.py
  • tools/android/build_split_manifest.py
  • tools/android/stubify_manifest.py
  • tools/android/aar_native_libs_zip_creator.py
  • tools/aquery_differ/aquery_differ.py
  • tools/jdk/proguard_whitelister.py
  • tools/ctexplain/ctexplain.py
copybara-service bot pushed a commit that referenced this issue Nov 30, 2022
@aiuto @copybara-github
Stop using absl flags in (the deprecated) pkg_tar.
4193ddc 
#16882  We are trying to reduce the footprint of things bundled into Bazel under @tools//.

PiperOrigin-RevId: 492028314
Change-Id: Ic2271f7c79151e9757a741bc17f36183abfde437
copybara-service bot pushed a commit that referenced this issue Dec 7, 2022
@aiuto @copybara-github
Stop using absl flags in proguard_whitelister.
7f5dd0a 
#16882

PiperOrigin-RevId: 493696178
Change-Id: I61dbfb6f35fd5be77aa97f579d69b26bf8b01f89
@idanakav
Copy link

Apart from tech debt, I'm noticing an issue as well in tools/android/incremental_install.py after parsing the extra_adb_arg will end up with duplicated values if they are read from a flagfile.

limdor added a commit to limdor/bazel that referenced this issue May 15, 2023
@limdor
Stop using absl flags
f34205f 
See bazelbuild#16882
@limdor limdor mentioned this issue May 15, 2023
Open
@limdor
Copy link
Contributor

limdor commented May 15, 2023 •
edited
Loading

Is it limited to these files? I'm asking because I saw is used in scripts/generate_fish_completion.py
I created a PR for it #18407

limdor added a commit to limdor/bazel that referenced this issue May 15, 2023
@limdor
Stop using absl flags
ef3917c 
See bazelbuild#16882
@limdor
Copy link
Contributor

limdor commented May 15, 2023

I pushed a second commit for scripts/docs/create_release_docs.py

@aiuto
Copy link
Contributor Author

aiuto commented May 16, 2023

Is it limited to these files?
It only pays back the effort if done in the helpers. That reduces the size of the Bazel image and eliminates one runtime dependency.

limdor added a commit to limdor/bazel that referenced this issue May 17, 2023
@limdor
Stop using absl flags
6255528 
See bazelbuild#16882
@limdor limdor mentioned this issue May 17, 2023
Draft
@github-actions GitHub Actions
Copy link

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 90 days unless any other activity occurs. If you think this issue is still relevant and should stay open, please post any comment here and the issue will no longer be marked as stale.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Jul 20, 2024
@github-actions GitHub Actions
Copy link

This issue has been automatically closed due to inactivity. If you're still interested in pursuing this, please post @bazelbuild/triage in a comment here and we'll take a look. Thanks!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale Issues or PRs that are stale (no activity for 30 days) type: process
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@idanakav @aiuto @limdor