Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.4.0 - December 2022 #16663

Closed
6 tasks done
ShreeM01 opened this issue Nov 4, 2022 · 28 comments
Closed
6 tasks done

Release 5.4.0 - December 2022 #16663

ShreeM01 opened this issue Nov 4, 2022 · 28 comments
Labels
P1 I'll work on this now. (Assignee required) release team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: process

Comments

@ShreeM01
Copy link
Contributor

ShreeM01 commented Nov 4, 2022

Status of Bazel 5.4.0

To report a release-blocking bug, please add a comment with the text @bazel-io flag to the issue. A release manager will triage it and add it to the milestone.

To cherry-pick a mainline commit into 5.4, simply send a PR against the release-5.4.0 branch.

Task list:

@ShreeM01 ShreeM01 added P1 I'll work on this now. (Assignee required) type: process release team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website labels Nov 4, 2022
@keertk keertk changed the title Release 5.4.0 - November 2022 Release 5.4.0 - December 2022 Nov 22, 2022
@keertk keertk pinned this issue Nov 22, 2022
@aiuto
Copy link
Contributor

aiuto commented Nov 30, 2022 via email

@keertk
Copy link
Member

keertk commented Nov 30, 2022

Hi @aiuto We're creating the first release candidate for 5.4.0 soon (today or tomorrow) and hopefully we push out the final release sometime next week. There are no open release blockers at the moment, but let us know if there's anything else that you'd like to include.
Draft release notes can be found here.

cc @kshyanashree @meteorcloudy @Wyverald

@aiuto
Copy link
Contributor

aiuto commented Nov 30, 2022 via email

@aiuto
Copy link
Contributor

aiuto commented Nov 30, 2022 via email

@meteorcloudy
Copy link
Member

@kshyanashree is managing the release and all cherry picks have been reviewed by a Bazel team member (either the change author or reviewer) to make sure they are backwards compatible.

@meteorcloudy
Copy link
Member

meteorcloudy commented Dec 1, 2022

OK. I have 2 PRs in flight now.

Can you mark those PRs with 5.4.0 release blockers milestone?

@aiuto
Copy link
Contributor

aiuto commented Dec 1, 2022 via email

@meteorcloudy
Copy link
Member

Sorry, I meant 5.4.0 release blockers, I updated the comment in the github issue, but maybe you received the old comment in email.

@ShreeM01
Copy link
Contributor Author

ShreeM01 commented Dec 1, 2022

Bazel 5.4.0rc1 is now available for those that want to try it out.

You can download it from:
https://releases.bazel.build/5.4.0/rc1/index.html

Please report regressions to https://github.com/bazelbuild/bazel/issues as soon as possible.

@aiuto
Copy link
Contributor

aiuto commented Dec 1, 2022 via email

@Wyverald
Copy link
Member

Wyverald commented Dec 1, 2022

properly cc'ing @brandjon

@meteorcloudy
Copy link
Member

@aiuto Is the change already in Bazel HEAD? How much work needed for backporting that to 5.4?

@aiuto
Copy link
Contributor

aiuto commented Dec 2, 2022 via email

@meteorcloudy
Copy link
Member

I could make a case that we do not want to put it in 5.x so that we encourage users to migrate to 6.

OK, then we'll release 5.4.0 as planned. We can encourage users to use 6, and if really necessary we can make a 5.5.0 release for the changes.

@comius
Copy link
Contributor

comius commented Dec 8, 2022

Hey, can we have one more cherry-pick on 5.4.0? The Exec platform per toolchain, needs a new parameter on ctx.actions.run. Adding a no-op parameter would make the migration smoother. But we'd need to cherry-pick it to 6.0.0 as well.

cc @kotlaja

@meteorcloudy
Copy link
Member

I think it's fine, @comius Can you or @kotlaja send a PR to the release-5.4.0 branch?

@kotlaja
Copy link
Contributor

kotlaja commented Dec 8, 2022

Following @comius comment: a247502. Thanks!

@meteorcloudy
Copy link
Member

@kshyanashree Can you cherry pick a247502 to both 5.4.0 and 6.0.0?

@ShreeM01
Copy link
Contributor Author

ShreeM01 commented Dec 8, 2022

@kshyanashree Can you cherry pick a247502 to both 5.4.0 and 6.0.0?

Yes @meteorcloudy! I am on it. Thanks :)

@ShreeM01
Copy link
Contributor Author

Bazel 5.4.0rc2 is now available for those that want to try it out.

You can download it from:
https://releases.bazel.build/5.4.0/rc2/index.html

Please report regressions to https://github.com/bazelbuild/bazel/issues as soon as possible.

@aiuto
Copy link
Contributor

aiuto commented Dec 13, 2022 via email

@ShreeM01
Copy link
Contributor Author

ShreeM01 commented Dec 15, 2022

5.4.0 is now out!

@petemounce Could you please update Chocolatey? Thanks!

@excitoon @vbatts Could you please update Scoop & Fedora package with 5.4.0? Thanks!

@keertk keertk unpinned this issue Dec 16, 2022
@petemounce
Copy link
Contributor

Done. Ping for adding into CI cc @meteorcloudy.

@ShreeM01
Copy link
Contributor Author

Done. Ping for adding into CI cc @meteorcloudy.

Thanks @petemounce!

@keertk
Copy link
Member

keertk commented Apr 6, 2023

We're working on a patch release (5.4.1) to address a few compatibility issues -- RC1 is now available for those that want to try it out.
You can download it from: https://releases.bazel.build/5.4.1/rc1/index.html
Please report regressions to https://github.com/bazelbuild/bazel/issues as soon as possible.

Draft release notes can be found here.

@aiuto
Copy link
Contributor

aiuto commented Apr 6, 2023 via email

@keertk
Copy link
Member

keertk commented Apr 6, 2023

Hi @aiuto there's no 5.5.0 planned.
We planned to do 5.4.1 just 2 days ago to address some incompatibility issues discussed here: #17958 (comment)

We won't be doing the final 5.4.1 release until at least 7 days from now as per the release policy, so feel free to submit additional PRs to the release-5.4.1 branch if needed. We can create another RC.

@keertk
Copy link
Member

keertk commented Apr 11, 2023

Release 5.4.1 progress can be tracked here moving forward: #18032

(New patch releases 6.1.2 and 4.2.4 are also currently in the works with the same fixes, fyi)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 I'll work on this now. (Assignee required) release team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: process
Projects
None yet
Development

No branches or pull requests

8 participants