-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 5.4.0 - December 2022 #16663
Comments
Is there an updated timeline for this?
Is there a public list of changes we want to hold the release for?
…On Fri, Nov 4, 2022 at 4:40 PM kshyanashree ***@***.***> wrote:
Status of Bazel 5.4.0
- Expected release date: Next week
- List of release blockers
<https://github.com/bazelbuild/bazel/milestone/45>
To report a release-blocking bug, please add a comment with the text @bazel-io
flag to the issue. A release manager will triage it and add it to the
milestone.
To cherry-pick a mainline commit into 5.4, simply send a PR against the
release-5.4.0 branch.
Task list:
- Create draft release announcement
<https://docs.google.com/document/d/1wDvulLlj4NAlPZamdlEVFORks3YXJonCjyuQMUQEmB0/edit>
- Send for review the release announcement PR:
- Push the release, notify package maintainers:
- Update the documentation
- Push the blog post
- Update the release page
<https://github.com/bazelbuild/bazel/releases/>
—
Reply to this email directly, view it on GitHub
<#16663>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXHHHETFF245WPAFT44T3LWGVYERANCNFSM6AAAAAARXRGTBA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Hi @aiuto We're creating the first release candidate for 5.4.0 soon (today or tomorrow) and hopefully we push out the final release sometime next week. There are no open release blockers at the moment, but let us know if there's anything else that you'd like to include. |
+Radhika Advani ***@***.***> +Yun Peng ***@***.***>
But what I should have asked is "who is the release manager?"
Someone should be vetting all backported features and fixes so that we know
they are relevant and don't break backwards compatibility.
…On Wed, Nov 30, 2022 at 4:49 PM Tony Aiuto ***@***.***> wrote:
Is there an updated timeline for this?
Is there a public list of changes we want to hold the release for?
On Fri, Nov 4, 2022 at 4:40 PM kshyanashree ***@***.***>
wrote:
> Status of Bazel 5.4.0
>
> - Expected release date: Next week
> - List of release blockers
> <https://github.com/bazelbuild/bazel/milestone/45>
>
> To report a release-blocking bug, please add a comment with the text @bazel-io
> flag to the issue. A release manager will triage it and add it to the
> milestone.
>
> To cherry-pick a mainline commit into 5.4, simply send a PR against the
> release-5.4.0 branch.
>
> Task list:
>
> - Create draft release announcement
> <https://docs.google.com/document/d/1wDvulLlj4NAlPZamdlEVFORks3YXJonCjyuQMUQEmB0/edit>
> - Send for review the release announcement PR:
> - Push the release, notify package maintainers:
> - Update the documentation
> - Push the blog post
> - Update the release page
> <https://github.com/bazelbuild/bazel/releases/>
>
> —
> Reply to this email directly, view it on GitHub
> <#16663>, or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAXHHHETFF245WPAFT44T3LWGVYERANCNFSM6AAAAAARXRGTBA>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
|
OK. I have 2 PRs in flight now.
…On Wed, Nov 30, 2022 at 5:08 PM keertk ***@***.***> wrote:
Hi @aiuto <https://github.com/aiuto> We're creating the first release
candidate for 5.4.0 soon (today or tomorrow) and hopefully we push out the
final release sometime next week. There are no open release blockers
<https://github.com/bazelbuild/bazel/milestone/45> at the moment, but let
us know if there's anything else that you'd like to include.
Draft release notes can be found here
<https://docs.google.com/document/d/1pu2ARPweOCTxPsRR8snoDtkC9R51XWRyBXeiC6Ql5so/edit#heading=h.1ldj0zgvx6cd>
.
cc @kshyanashree <https://github.com/kshyanashree> @meteorcloudy
<https://github.com/meteorcloudy> @Wyverald <https://github.com/Wyverald>
—
Reply to this email directly, view it on GitHub
<#16663 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXHHHB4M3F6TJKUM3NUWR3WK7F6NANCNFSM6AAAAAARXRGTBA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@kshyanashree is managing the release and all cherry picks have been reviewed by a Bazel team member (either the change author or reviewer) to make sure they are backwards compatible. |
Can you mark those PRs with |
Why? They are already in 6.0? I don't understand the connection.
…On Thu, Dec 1, 2022, 4:31 AM Yun Peng ***@***.***> wrote:
OK. I have 2 PRs in flight now.
Can you mark those PRs with 6.0.0 release blockers milestone?
—
Reply to this email directly, view it on GitHub
<#16663 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXHHHHOWWPIBVSOQWOTNELWLBV7ZANCNFSM6AAAAAARXRGTBA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sorry, I meant |
Bazel 5.4.0rc1 is now available for those that want to try it out. You can download it from: Please report regressions to https://github.com/bazelbuild/bazel/issues as soon as possible. |
@jon Brandvein ***@***.***>
Is there any chance of getting the starlark provider "init" functionality
into 5.4?
…On Thu, Dec 1, 2022 at 9:43 AM kshyanashree ***@***.***> wrote:
Bazel 5.4.0rc1 is now available for those that want to try it out.
You can download it from:
https://releases.bazel.build/5.4.0/rc1/index.html
Please report regressions to https://github.com/bazelbuild/bazel/issues
as soon as possible.
—
Reply to this email directly, view it on GitHub
<#16663 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXHHHDKVQBJWFFX2MLOLQ3WLC2Q5ANCNFSM6AAAAAARXRGTBA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
properly cc'ing @brandjon |
@aiuto Is the change already in Bazel HEAD? How much work needed for backporting that to 5.4? |
The changes are in Bazel, but I don't know the difficulty.
I asked about it because:
- I tried to use an init method in a provider constructor in rules_license.
- that helped improve the security of a rule used for compliance work
- but then CI fails because it runs with 5.x
So, I could sweep the issue under the rug and wait until CI is all 6.x,
but that won't help with having a single rule set that is compatible with
5 and 6. OTOH.... initializers are an obscure feature that helps with
visibility protection. Mostly users need it, but rule authors do not.
I could make a case that we do not want to put it in 5.x so that
we encourage users to migrate to 6.
…On Thu, Dec 1, 2022 at 10:11 AM Yun Peng ***@***.***> wrote:
@aiuto <https://github.com/aiuto> Is the change already in Bazel HEAD?
How much work needed for backporting that to 5.4?
—
Reply to this email directly, view it on GitHub
<#16663 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXHHHG2GNXSMNYAUEIIQM3WLC52JANCNFSM6AAAAAARXRGTBA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
OK, then we'll release 5.4.0 as planned. We can encourage users to use 6, and if really necessary we can make a 5.5.0 release for the changes. |
Hey, can we have one more cherry-pick on 5.4.0? The Exec platform per toolchain, needs a new parameter on cc @kotlaja |
@kshyanashree Can you cherry pick a247502 to both 5.4.0 and 6.0.0? |
Yes @meteorcloudy! I am on it. Thanks :) |
Bazel 5.4.0rc2 is now available for those that want to try it out. You can download it from: Please report regressions to https://github.com/bazelbuild/bazel/issues as soon as possible. |
It looks like there are some UTF-8 manglings in the list of contributors
section.
…On Tue, Dec 13, 2022 at 12:46 PM kshyanashree ***@***.***> wrote:
Bazel 5.4.0rc2 is now available for those that want to try it out.
You can download it from:
https://releases.bazel.build/5.4.0/rc2/index.html
Please report regressions to https://github.com/bazelbuild/bazel/issues
as soon as possible.
—
Reply to this email directly, view it on GitHub
<#16663 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXHHHAA7M74NAHXIWGURCTWNCY6BANCNFSM6AAAAAARXRGTBA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
5.4.0 is now out! @petemounce Could you please update Chocolatey? Thanks! @excitoon @vbatts Could you please update Scoop & Fedora package with 5.4.0? Thanks! |
Done. Ping for adding into CI cc @meteorcloudy. |
Thanks @petemounce! |
We're working on a patch release (5.4.1) to address a few compatibility issues -- RC1 is now available for those that want to try it out. Draft release notes can be found here. |
We need a better scheme for understanding the release timelines. There are
some things I would have backported to 5.x if I had known we were doing a
new release.
Is a 5.5.0 planned?
…On Wed, Apr 5, 2023 at 10:03 PM keertk ***@***.***> wrote:
We're working on a patch release (5.4.1) to address a few compatibility
issues -- RC1 is now available for those that want to try it out.
You can download it from:
https://releases.bazel.build/5.4.1/rc1/index.html
Please report regressions to https://github.com/bazelbuild/bazel/issues
as soon as possible.
Release notes can be found here
<https://docs.google.com/document/d/1pu2ARPweOCTxPsRR8snoDtkC9R51XWRyBXeiC6Ql5so/edit#heading=h.6ke4hvqbh7sl>
.
—
Reply to this email directly, view it on GitHub
<#16663 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXHHHBGXRU6JVPL7LSTEZTW7YP6TANCNFSM6AAAAAARXRGTBA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi @aiuto there's no 5.5.0 planned. We won't be doing the final 5.4.1 release until at least 7 days from now as per the release policy, so feel free to submit additional PRs to the |
Status of Bazel 5.4.0
To report a release-blocking bug, please add a comment with the text
@bazel-io flag
to the issue. A release manager will triage it and add it to the milestone.To cherry-pick a mainline commit into 5.4, simply send a PR against the
release-5.4.0
branch.Task list:
Push the blog postThe text was updated successfully, but these errors were encountered: