Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--incompatible_remote_build_event_upload_respect_no_cache doesn't work with BwtB #15527

Closed
brentleyjones opened this issue May 19, 2022 · 2 comments
Closed

--incompatible_remote_build_event_upload_respect_no_cache doesn't work with BwtB #15527

brentleyjones opened this issue May 19, 2022 · 2 comments
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Remote-Exec Issues and PRs for the Execution (Remote) team type: bug

Comments

@brentleyjones
Copy link
Contributor

Description of the bug:

--incompatible_remote_build_event_upload_respect_no_cache doesn't prevent the upload of no-cache/no-remote blobs if you use --remote_download_minimal or --remote_download_toplevel.

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

bazelrc:

build --bes_results_url=https://app.buildbuddy.io/invocation/
build --bes_backend=grpcs://remote.buildbuddy.io
build --remote_cache=grpcs://remote.buildbuddy.io
build --modify_execution_info=.*=+no-remote
build --incompatible_remote_build_event_upload_respect_no_cache

The above will only upload the timing profile, as expected.

Adding --remote_download_minimal or --remote_download_toplevel will cause other blobs to be uploaded.

Which operating system are you running Bazel on?

macOS

What is the output of bazel info release?

5.0.0 through last-green

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse master; git rev-parse HEAD ?

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response
@brentleyjones
Copy link
Contributor Author

@bazelbuild/remote-execution

@sgowroji sgowroji added type: bug untriaged team-Remote-Exec Issues and PRs for the Execution (Remote) team labels May 19, 2022
@brentleyjones
Copy link
Contributor Author

I've seen this with other sets of flags (that I don't have a reproducer for), so it may be a larger surface area than listed in the title.

@coeuvre any thoughts?

@meisterT meisterT added P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed untriaged labels Jul 14, 2022
@meisterT meisterT mentioned this issue Jul 27, 2022
Closed
@meisterT meisterT added P2 We'll consider working on this in future. (Assignee optional) and removed P3 We're not considering working on this, but happy to review a PR. (No assignee) labels Jul 27, 2022
@coeuvre coeuvre mentioned this issue Aug 2, 2022
Closed
sgowroji pushed a commit to sgowroji/bazel that referenced this issue Aug 4, 2022
@coeuvre @sgowroji
Fix an issue that `incompatible_remote_build_event_upload_respect_no_…
c6da186 
…cache` doesn't work with BwtB.

The root cause is we use `Path` as key to check which files are omitted, but it also compares the underlying filesystem. When BwtB is enabled, the filesystem for the file is different so we failed to mark the file as omitted.

This change fixes that by using `PathFragment` as key.

Fixes bazelbuild#15527.

Closes bazelbuild#16023.

PiperOrigin-RevId: 465284879
Change-Id: I49bbd7a6055e0f234b4ac86a224886bd85797f71
@sgowroji sgowroji mentioned this issue Aug 4, 2022
Merged
sgowroji added a commit that referenced this issue Aug 4, 2022
@sgowroji @coeuvre
Fix an issue that `incompatible_remote_build_event_upload_respect_no_… (
82452c7 
#16045)

* Fix an issue that `incompatible_remote_build_event_upload_respect_no_…

…cache` doesn't work with BwtB.

The root cause is we use `Path` as key to check which files are omitted, but it also compares the underlying filesystem. When BwtB is enabled, the filesystem for the file is different so we failed to mark the file as omitted.

This change fixes that by using `PathFragment` as key.

Fixes #15527.

Closes #16023.

PiperOrigin-RevId: 465284879
Change-Id: I49bbd7a6055e0f234b4ac86a224886bd85797f71

* Update ByteStreamBuildEventArtifactUploader changes

Removing the import as it is throwing the error

Co-authored-by: Chi Wang <[email protected]>
ShreeM01 added a commit that referenced this issue Aug 9, 2022
@ShreeM01 @tjgq
@ted-xie @sgowroji @coeuvre
Release 5.3.0 (#16074)
2077c54 
* Updated Codeowners file (#16032)

* Propagate the error message when a credential helper fails. (#16030)

Closes #16012.

PiperOrigin-RevId: 464732834
Change-Id: If51ce914098ff17ffe23fa4614947e7f4a5088dc

Co-authored-by: Tiago Quelhas <[email protected]>

* Migrate legacy desugar wrapper to new rlocation() (#16025)

RELNOTES: Fix for desugaring failure on Bazel+Android+Windows build scenario.
PiperOrigin-RevId: 464654335
Change-Id: I845093b134dc68ae541603008fe7fee701c7451c

Co-authored-by: Gowroji Sunil <[email protected]>

* Correctly report errors thrown by CommandLinePathFactory#create. (#16036)

This method is called while initializing the remote module [1]. Any exceptions
not derived from java.io.IOException cause a silent server crash.

[1] https://cs.opensource.google/bazel/bazel/+/master:src/main/java/com/google/devtools/build/lib/remote/RemoteModule.java;l=436;drc=f3211f00ae08746b5794ab01d404c32b43146aba

Closes #16022.

PiperOrigin-RevId: 464997904
Change-Id: I87fd5eaeb562d849bb830d68f1bfbbf06f6e0ea9

Co-authored-by: Tiago Quelhas <[email protected]>

* Fix an issue that `incompatible_remote_build_event_upload_respect_no_… (#16045)

* Fix an issue that `incompatible_remote_build_event_upload_respect_no_…

…cache` doesn't work with BwtB.

The root cause is we use `Path` as key to check which files are omitted, but it also compares the underlying filesystem. When BwtB is enabled, the filesystem for the file is different so we failed to mark the file as omitted.

This change fixes that by using `PathFragment` as key.

Fixes #15527.

Closes #16023.

PiperOrigin-RevId: 465284879
Change-Id: I49bbd7a6055e0f234b4ac86a224886bd85797f71

* Update ByteStreamBuildEventArtifactUploader changes

Removing the import as it is throwing the error

Co-authored-by: Chi Wang <[email protected]>

Co-authored-by: Tiago Quelhas <[email protected]>
Co-authored-by: Ted <[email protected]>
Co-authored-by: Gowroji Sunil <[email protected]>
Co-authored-by: Chi Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Remote-Exec Issues and PRs for the Execution (Remote) team type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix an issue that `incompatible_remote_build_event_upload_respect_no_… coeuvre/bazel
3 participants
@brentleyjones @meisterT @sgowroji