-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arcanist Integration #145
Comments
Not having worked with Phabricator or Arcanist, I don't follow what the On Tue, Apr 21, 2015 at 12:26 AM, Cody Schroeder [email protected]
|
I'm trying to get a bazel-examples repo out there, which would be a good place for contributions like these. |
See CampfireTestEngine.php for Kythe's current support. |
That's cool. Yes, I guess we could hook that up with blaze query. For the On Tue, Apr 21, 2015 at 6:20 PM, Cody Schroeder [email protected]
|
Is there any current way to output a structured format of the test results? |
we write a .cache_status file which is a protobuf. It's not been intended as a public API, but the analogon inside google is used to collect test/build status results. |
I also found that it is hard to query a file's rdeps when a file may or may not be covered by a build target. Bazel will just fail if it is given some random file. Is there a way to ignore such files during a query? |
How does it fail? On Fri, May 1, 2015 at 11:39 PM, Cody Schroeder [email protected]
|
If you query a file path that is used in a target, it prints the path as a target of the same package:
Querying a file that is not declared ends up with this kind of error:
This makes it hard to do this general query:
The above query also fails when given |
Does -k help? On Monday, May 4, 2015, Cody Schroeder [email protected] wrote:
|
Yeah, |
Any updates on this? I'd love for this to be supported natively. |
The Java test runner has landed in 0e396b8 and Philip has a inflight change for making sandboxing allow to output XML file. It should arrive somewhere next week. For now you can have the xml outputs by disabling sandboxing. For the rest of the piping to Arcanist, we would welcome any contribution :) |
OK, I can give it a shot. Any docs on how to utilize it? |
I don't really know what kind of doc you are expecting but if you run bazel On Sat, Jan 16, 2016, 7:34 PM Derek Perez [email protected] wrote:
|
Oh, this hasn't hit a release version yet has it? |
No it should be in 0.2 (somewhere at the end of the month). On Sat, Jan 16, 2016 at 7:51 PM Derek Perez [email protected]
|
(and even then it should still requires the --nolegacy_bazel_java_test flag) On Sat, Jan 16, 2016 at 7:52 PM Damien Martin-guillerez [email protected]
|
Cool, please ping this thread when its in a release and I'll make it happen. |
It is now in a release. |
I am closing this one as we now have XML output for every test and query. There is no more feature that should be needed on bazel side. |
I managed to make a more lightweight version of Kythe's bazel-arcanist integration. It uses --build_event_json_file and it is (IMHO) more developer friendly because it shows progress using bazel's output: https://github.com/igorgatis/bazel-arcanist |
It'd be nice to have support for Bazel as a ArcanistUnitTestEngine so that
arc unit
andarc diff
run all of a workspace's tests before submitting a review to Phabricator.Kythe current has primitive arcanist support for its Bazel-like build system. It shouldn't be too hard for me to port it specifically for Kythe, but perhaps it would make a good contribution to the Bazel repo for other projects. Thoughts?
The text was updated successfully, but these errors were encountered: