Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cquery should support --query_file #12924

Closed
luna-duclos opened this issue Jan 29, 2021 · 6 comments
Closed

cquery should support --query_file #12924

luna-duclos opened this issue Jan 29, 2021 · 6 comments
Assignees
@aiuto
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Configurability platforms, toolchains, cquery, select(), config transitions type: feature request

Comments

@luna-duclos
Copy link

Description of the problem / feature request:

bazel cquery should support the --query_file= argument, similar to bazel query,

Feature requests: what underlying problem are you trying to solve with this feature?

this would allow us not to have to care about, for example, the relatively short command line length on macOS when writing queries.
As well as being able to programatically generate big queries and not have to worry about their length at all

What operating system are you running Bazel on?

We run bazel on linux and macOS

What's the output of bazel info release?

release 4.0.0

What's the output of git remote get-url origin ; git rev-parse master ; git rev-parse HEAD ?

N/A
@oquenchil oquenchil added team-Configurability platforms, toolchains, cquery, select(), config transitions type: feature request untriaged labels Feb 4, 2021
@aiuto aiuto added the P1 I'll work on this now. (Assignee required) label Feb 12, 2021
@aiuto aiuto self-assigned this Feb 12, 2021
@aiuto aiuto removed the untriaged label Feb 12, 2021
@gregestren gregestren added P2 We'll consider working on this in future. (Assignee optional) and removed P1 I'll work on this now. (Assignee required) labels Apr 15, 2021
@jin
Copy link
Member

jin commented Nov 2, 2022

Greg, is the premise of this FR sound? Folks using Bazel in AOSP could use this. Also pinged on the internal doc.

@brentleyjones
Copy link
Contributor

@gregestren Seems like fb23246 could go into a 6.x release (as in cherry-picked right now)? I saw it mentioned here and I was surprised it didn't make it into 6.0

aiuto pushed a commit that referenced this issue Feb 28, 2023
@aiuto
Allows --query_file to be used for cquery and aquery too.
3f2c71c 
Fixes #12924.

RELNOTES[NEW]: The `aquery` and `cquery` commands now respect the
`--query_file` flag just like the `query` command.

PiperOrigin-RevId: 487689456
Change-Id: Ia2c9d85e88fdf769a823eaf7b6585a77d654ae70
@aiuto aiuto mentioned this issue Feb 28, 2023
Closed
@aiuto
Copy link
Contributor

aiuto commented Mar 1, 2023

@sgowroji Can you take care of the backport to the next 6.x release?

@aiuto aiuto reopened this Mar 1, 2023
@sgowroji
Copy link
Member

sgowroji commented Mar 1, 2023

Sure @aiuto. Thanks for tagging.

@keertk
Copy link
Member

keertk commented Mar 2, 2023

@bazel-io fork 6.2.0

@bazel-io bazel-io mentioned this issue Mar 2, 2023
Closed
This was referenced Mar 19, 2023
Closed
Merged
keertk added a commit that referenced this issue Mar 20, 2023
@keertk
[6.2.0] Allows --query_file to be used for cquery and aquery too. (#1…
ee32eff 
…7823)

Fixes #12924.

RELNOTES[NEW]: The aquery and cquery commands now respect the --query_file flag just like the query command.

PiperOrigin-RevId: 487689456
Change-Id: Ia2c9d85e88fdf769a823eaf7b6585a77d654ae70
@keertk
Copy link
Member

keertk commented Mar 20, 2023

Included in the release-6.2.0 branch: #17823.
Closing this issue.

@keertk keertk closed this as completed Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aiuto aiuto

Labels
P2 We'll consider working on this in future. (Assignee optional) team-Configurability platforms, toolchains, cquery, select(), config transitions type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@brentleyjones @jin @aiuto @gregestren @luna-duclos @oquenchil @sgowroji @keertk