"bazel clean" failure when Starlark options present in "build" lines in .bazelrc

[stefanbucur]

Description of the problem / feature request:

When I use a label-typed Bazel option on a build line in a .bazelrc file, Bazel fails with an error:

# .bazelrc file
build --//fuzzing:cc_engine=//fuzzing/engines:libfuzzer

$ bazel clean
ERROR: Unrecognized arguments: --//fuzzing:cc_engine=//fuzzing/engines:libfuzzer

This is quite problematic for us, because we offer this option in a library, and developers are expected to be able to override the option in their own workspaces.

Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

$ git clone [email protected]:bazelbuild/rules_fuzzing.git
$ cd rules_fuzzing
$ [edit the .bazelrc file and add the "build --//fuzzing:cc_engine=//fuzzing/engines:libfuzzer" snippet]
$ bazel clean

What operating system are you running Bazel on?

Debian

What's the output of bazel info release?

release 3.7.2

[aiuto]

Only sending to configurability because of command line parsing, but I think any team could do this.

[Yannic]

Looks like this was previously fixed in #11506 (and I think I remember it working correctly).

/cc @juliexxia @katre

[stefanbucur]

I've just checked, and Bazel does indeed display a warning when using --//fuzzing:cc_engine_sanitizer, which is a string-typed flag. However, it triggers an error for --//fuzzing:cc_engine, which is a label-typed flag. So maybe this case was not handled in #11506?

[juliexxia]

(Context: I'm moving on from Bazel on friday and spending some time triaging all bugs assigned to me before unassigning myself)

Just tried the repro with release bazel and got the described error, but tried with bazel built at head and got the expected warning. I haven't tried to figure out what change resulted in that but I'd request trying this again when the new release comes out and see if it's still an issue.

[gregestren]

Status: let's wait until the next Bazel release to verify the issue, as @juliexxia suggested.

After that point if anyone still sees the problem please ping this thread.

[gregestren]

This fails for me with bazel 4.1.0. I'll look further.

[gregestren]

Dug in and I'm confused. :(

This works for me with bazel@head. But not bazel 4.1.0.

• Bazel 4.1's release bug is baselined to 4.0.0 ( 6b33bdb), which itself is baselined to 37a429a, which was committed Nov 18, 2020
• The first fix for clean, 32e1313, was committed May 27, 2020
• The fix for clean, 69d4ace, was commited May 29, 2020

What would be different between 4.1.0 and head, then?

Something is not adding up here.

[gregestren]

CleanCommand at the 4.1.0 tag: https://github.com/bazelbuild/bazel/blob/4.1.0/src/main/java/com/google/devtools/build/lib/runtime/commands/CleanCommand.java. I see the relevant code:

bazel/src/main/java/com/google/devtools/build/lib/runtime/commands/CleanCommand.java

Lines 133 to 135 in c4975ef

	Event.warn(
	"Blaze clean does not support starlark options. Ignoring options: "
	+ removedStarlarkOptions));

And I don't see any interesting changes to the file since: https://github.com/bazelbuild/bazel/commits/master/src/main/java/com/google/devtools/build/lib/runtime/commands/CleanCommand.java

[gregestren]

git bisect led me to 64157a5 from Dec 22, 2020. We can request this as a cherrypick for 4.2.0.

[gregestren]

Closing this bug, now that it's been cherrypick-requested for 4.2.0.

[CareF]

Still get a warning message of this for bazel 5.1.0