-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Respect Starlark options with values in
removeStarlarkOptions()
Related: #11301 (Partially fixed in 2ec58f6) Motivation: `StarlarkOptionsParser.removeStarlarkOptions()` doesn't take the case into account where the specified Starlark option has a value, e.g. `--//my_rules/custom_flags:foo=bar`. Modifications: - Do not pass a Starlark flag value when validating the flag name. Result: `bazel info` does not fail anymore when `.bazelrc` contains a statement like the following: build --//my_rules/custom_flags:foo=bar Closes #12648. PiperOrigin-RevId: 348676049
- Loading branch information
1 parent
4369cc9
commit 64157a5
Showing
2 changed files
with
18 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters