Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--repo_env should be a common option #12689

Closed
sjoerdvisscher opened this issue Dec 11, 2020 · 1 comment
Closed

--repo_env should be a common option #12689

sjoerdvisscher opened this issue Dec 11, 2020 · 1 comment
Labels
P2 We'll consider working on this in future. (Assignee optional) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: bug

Comments

@sjoerdvisscher
Copy link

Description of the problem / feature request:

Currently --repo_env is not a common argument. I don't see how it could be useful if I just set it on build: If I first do bazel build it applies the repo_env and downloads the repository data. But if I then do bazel query repo_env is no longer applied, the repository cache is invalidated and all the repository data is downloaded again.

If I could just set --repo_env on common this would not happen.
@aiuto aiuto added bad error messaging Issues where users get stuck because they don't understand what they did wrong team-Configurability platforms, toolchains, cquery, select(), config transitions untriaged and removed bad error messaging Issues where users get stuck because they don't understand what they did wrong labels Jan 7, 2021
@aiuto aiuto added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. and removed team-Configurability platforms, toolchains, cquery, select(), config transitions labels Jan 15, 2021
@sventiffe sventiffe added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Feb 10, 2021
@philwo philwo added P2 We'll consider working on this in future. (Assignee optional) type: bug and removed untriaged labels Feb 10, 2021
@chancila chancila mentioned this issue Feb 12, 2021
Closed
bazel-io pushed a commit that referenced this issue Mar 25, 2021
@chancila @copybara-github
Move --repo_env to common options
c2bdd03 
Move --repo_env into common options and inject the value through CommandEnvironment since CommonCommandOptions cannot be accessed in SkyframeExecutor directly due to a circular dependency in the build.

Addresses #12689

Closes #13003.

PiperOrigin-RevId: 365035772
@UebelAndre UebelAndre mentioned this issue Apr 21, 2021
Merged
philwo pushed a commit that referenced this issue Apr 21, 2021
@chancila @philwo
Move --repo_env to common options
d737177 
Move --repo_env into common options and inject the value through CommandEnvironment since CommonCommandOptions cannot be accessed in SkyframeExecutor directly due to a circular dependency in the build.

Addresses #12689

Closes #13003.

PiperOrigin-RevId: 365035772
@chancila chancila mentioned this issue Apr 23, 2021
Closed
@philwo
Copy link
Member

philwo commented May 6, 2021

This was fixed via c2bdd03.

@philwo philwo closed this as completed May 6, 2021
@philwo philwo removed the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 We'll consider working on this in future. (Assignee optional) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sjoerdvisscher @philwo @aiuto @sventiffe