Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jdeps_test fails just on RBE #12685

Closed
meisterT opened this issue Dec 11, 2020 · 3 comments
Closed

jdeps_test fails just on RBE #12685

meisterT opened this issue Dec 11, 2020 · 3 comments
Labels
area-EngProd Bazel CI, infrastructure, bootstrapping, release, and distribution tooling P1 I'll work on this now. (Assignee required) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: bug

Comments

@meisterT
Copy link
Member

The jdeps test should make sure that we don't accidentally add deps on new JDK modules breaking Bazel because we only embed a minimized JDK.

We are seeing this test failing in presubmit, but only on RBE claiming that java.management should be removed.
This blocks even docs only changes, like https://buildkite.com/bazel/google-bazel-presubmit/builds/42189#7a0e47e2-b9ca-47f2-b71d-04e19caa98f7

Example log: https://storage.googleapis.com/bazel-untrusted-buildkite-artifacts/f1789ffa-fd21-400c-a8d7-5f9c7e262dc0/src/test/shell/bazel/jdeps_test/attempt_1.log
@meisterT meisterT added area-EngProd Bazel CI, infrastructure, bootstrapping, release, and distribution tooling P1 I'll work on this now. (Assignee required) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website labels Dec 11, 2020
@meisterT
Copy link
Member Author

Apparently we don't run tests on RBE in postsubmit, why?

bazel-io pushed a commit that referenced this issue Dec 11, 2020
@meisterT @copybara-github
Temporarily disable jdeps_test to work around #12685
89f8273 
There's no testing on RBE in postsubmit (why?) so we only need to disable it in presubmit.

PiperOrigin-RevId: 346944290
@meisterT meisterT mentioned this issue Dec 11, 2020
Closed
bazel-io pushed a commit that referenced this issue Dec 14, 2020
@meisterT @copybara-github
Also run RBE testing in postsubmit and align the two configs.
fa0b8ab 
The skew was discovered when looking at #12685

Closes #12687.

TESTED=https://buildkite.com/bazel/bazel-bazel/builds/14929#_
PiperOrigin-RevId: 347357189
mai93 pushed a commit to mai93/bazel that referenced this issue Dec 16, 2020
@meisterT @mai93
Also run RBE testing in postsubmit and align the two configs.
6207bda 
The skew was discovered when looking at bazelbuild#12685

Closes bazelbuild#12687.

TESTED=https://buildkite.com/bazel/bazel-bazel/builds/14929#_
PiperOrigin-RevId: 347357189
mai93 pushed a commit to mai93/bazel that referenced this issue Dec 16, 2020
@meisterT @mai93
Temporarily disable jdeps_test to work around bazelbuild#12685
8520ca5 
There's no testing on RBE in postsubmit (why?) so we only need to disable it in presubmit.

PiperOrigin-RevId: 346944290
@mai93 mai93 mentioned this issue Dec 16, 2020
Closed
@philwo
Copy link
Member

philwo commented Feb 9, 2021

Is this still an issue?

meisterT added a commit to meisterT/bazel that referenced this issue Feb 9, 2021
@meisterT
Test whether bazelbuild#12685 magically resolved itself.
7ac0e59
@meisterT
Copy link
Member Author

meisterT commented Feb 9, 2021

I think so, but #12982 will tell us.

https://buildkite.com/bazel/bazel-bazel-github-presubmit/builds/8288 is the run on buildkite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-EngProd Bazel CI, infrastructure, bootstrapping, release, and distribution tooling P1 I'll work on this now. (Assignee required) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@meisterT @philwo