Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blackbox workspace tests need a complete overhaul for maintainability #11184

Closed
aiuto opened this issue Apr 22, 2020 · 2 comments
Closed

blackbox workspace tests need a complete overhaul for maintainability #11184

aiuto opened this issue Apr 22, 2020 · 2 comments
Labels
P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: process

Comments

@aiuto
Copy link
Contributor

aiuto commented Apr 22, 2020

The set of tests under src/test/j.c.g/devtools/build/lib/blackbox is brittle and hard to maintain.

  • They depend on external repositories. So either have to keep those in sync with versions in //WORKSPACE or risk version skew.
    • we are not necessarily sharing the download cache with the main repo
    • version numbers and sha sums are embedded in java code.
    • the workspace rules are getting increasingly complex, where dependencies have to use deps patterns to download their deps
  • They dynamically generate content of WORKSPACE files which then are consumed in the same test
    • this is had to debug if you get the workspace rules wrong. These files could be generated by a BUILD rule and be data input to the tests.

Some suggestions:

@aiuto aiuto added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. untriaged labels Apr 22, 2020
aiuto added a commit to aiuto/bazel that referenced this issue Apr 22, 2020
@laurentlb laurentlb added P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) type: process and removed untriaged labels Apr 29, 2020
@philwo philwo added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Jun 15, 2020
@philwo philwo removed the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Nov 29, 2021
@github-actions
Copy link

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 14 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-bazeler". Please reach out to the triage team (@bazelbuild/triage) if you think this issue is still relevant or you are interested in getting the issue resolved.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label May 24, 2023
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

This issue has been automatically closed due to inactivity. If you're still interested in pursuing this, please reach out to the triage team (@bazelbuild/triage). Thanks!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: process
Projects
None yet
Development

No branches or pull requests

3 participants