Skip to content

Commit

Permalink
Move android_sdk_for_testing bind into Android{S,N}dkRepositoryRule s…
Browse files Browse the repository at this point in the history
…o that eventually we can remove it from Bazel's WORKSPACE file.

We'll need to wait for the next Bazel release to remove it from the WORKSPACE file. This should hopefully make the process of the Bazel sheriff running android_integration_test.sh a little easier.

--
PiperOrigin-RevId: 146789106
MOS_MIGRATED_REVID=146789106
  • Loading branch information
aj-michael authored and kchodorow committed Feb 7, 2017
1 parent 43765af commit eb46a1b
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,9 @@ public Map<String, Label> apply(Rule rule) {

return ImmutableMap.of(
"android/crosstool",
Label.parseAbsoluteUnchecked("@" + rule.getName() + "//:" + defaultToolchainName));
Label.parseAbsoluteUnchecked("@" + rule.getName() + "//:" + defaultToolchainName),
"android_ndk_for_testing",
Label.parseAbsoluteUnchecked("@" + rule.getName() + "//:files"));
}
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ public Map<String, Label> apply(Rule rule) {
builder.put("android/sdk", Label.parseAbsoluteUnchecked(prefix + "sdk"));
builder.put(
"android/dx_jar_import", Label.parseAbsoluteUnchecked(prefix + "dx_jar_import"));
builder.put("android_sdk_for_testing", Label.parseAbsoluteUnchecked(prefix + "files"));
return builder.build();
}
};
Expand Down
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
bind(name = "android/sdk")
bind(name = "android/crosstool", actual = "@bazel_tools//tools/cpp:toolchain")
bind(name = "android_sdk_for_testing", actual = "//:dummy")
bind(name = "android_ndk_for_testing", actual = "//:dummy")

0 comments on commit eb46a1b

Please sign in to comment.